Disable nrvo mir opt

[JakobDegen]

See #111005 and #110902 . The ICE can definitely be hit on stable, the miscompilation I'm not sure about. The pass makes some pretty sketchy assumptions though, and we should not have it on while that's the case.

I'm not going to work on actually fixing this, it's probably not excessively difficult though.

r? rust-lang/mir-opt

[rustbot]

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

[cjgillot]

Should we remove this pass entirely, and let dest-prop do it instead?

[JakobDegen]

If it were on by default, yes. Until then, I'm not so sure

[tmiasko]

@bors r+ rollup=never

[bors]

📌 Commit 74d9567c3eb52f3cb0ba748e285eab860f507013 has been approved by tmiasko

It is now in the queue for this repository.

[bors]

⌛ Testing commit 74d9567c3eb52f3cb0ba748e285eab860f507013 with merge 76faaae3124d4f4ecf5310e32c27f65d768dbfc9...

[bors]

💔 Test failed - checks-actions

[tmiasko]

@bors r+

[bors]

📌 Commit 02d4c2f4e5d7bf06f2100a2f7cc3b5f4c0828d1b has been approved by tmiasko

It is now in the queue for this repository.

[bors]

⌛ Testing commit 02d4c2f4e5d7bf06f2100a2f7cc3b5f4c0828d1b with merge 0bd1485d726d4b5f29d0ce904b3a1c7540f060ac...

[bors]

💔 Test failed - checks-actions

[tmiasko]

@bors r+

[bors]

📌 Commit 8e2da80 has been approved by tmiasko

It is now in the queue for this repository.

[bors]

⌛ Testing commit 8e2da80 with merge dfe3188...

[bors]

☀️ Test successful - checks-actions
Approved by: tmiasko
Pushing dfe3188 to master...

[rust-timer]

Finished benchmarking commit (dfe3188): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.2%, 2.1%]	109
Regressions ❌ (secondary)	0.5%	[0.1%, 0.9%]	55
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.5%	[0.2%, 2.1%]	109

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.2%	[1.2%, 1.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.5%	[-2.3%, -1.1%]	5
Improvements ✅ (secondary)	-3.2%	[-3.8%, -2.7%]	2
All ❌✅ (primary)	-1.1%	[-2.3%, 1.2%]	6

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.0%	[0.8%, 1.7%]	7
Regressions ❌ (secondary)	2.6%	[2.0%, 3.8%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.0%	[0.8%, 1.7%]	7

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.0%, 1.9%]	49
Regressions ❌ (secondary)	0.1%	[0.0%, 0.2%]	13
Improvements ✅ (primary)	-0.1%	[-0.3%, -0.0%]	18
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[-0.3%, 1.9%]	67

Bootstrap: 656.767s -> 658.118s (0.21%)

[nnethercote]

Lots of regressions here. It sure would be nice if these could be regained, via dest-prop or any other means.