Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5 little typos #110441

Merged
merged 1 commit into from
Apr 18, 2023
Merged

5 little typos #110441

merged 1 commit into from
Apr 18, 2023

Conversation

kadiwa4
Copy link
Contributor

@kadiwa4 kadiwa4 commented Apr 17, 2023

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Apr 17, 2023

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 17, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 17, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

Noratrieb
Noratrieb reviewed Apr 17, 2023
View reviewed changes
library/core/src/ptr/const_ptr.rs
@@ -132,8 +132,8 @@ impl<T: ?Sized> *const T {
/// ```
#[unstable(feature = "ptr_to_from_bits", issue = "91126")]
#[deprecated(
since = "1.67",
note = "replaced by the `exposed_addr` method, or update your code \
since = "1.67.0",
Copy link
Member

@Noratrieb Noratrieb Apr 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, was this not set to CURRENT_RUSTC_VERSION and automatically changed in the release 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No (#95583)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @scottmcm :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, oops 🙃

TBH, these methods should just be deleted now. The new strict-provenance-related ones are the way forward.

scottmcm
scottmcm reviewed Apr 18, 2023
View reviewed changes
tests/codegen/optimize-attr-1.rs
@@ -9,7 +9,7 @@
// CHECK-LABEL: define{{.*}}i32 @nothing
// CHECK-SAME: [[NOTHING_ATTRS:#[0-9]+]]
// SIZE-OPT: ret i32 4
// SPEEC-OPT: ret i32 4
// SPEED-OPT: ret i32 4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice catch, since this was just a nop with the typo.

@scottmcm
Copy link
Member

r? @scottmcm
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 18, 2023

📌 Commit 8565383 has been approved by scottmcm

It is now in the queue for this repository.

@rustbot rustbot assigned scottmcm and unassigned thomcc Apr 18, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2023
@thomcc
Copy link
Member

thomcc commented Apr 18, 2023

Looks fine.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 18, 2023

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Apr 18, 2023

📌 Commit 8565383 has been approved by thomcc

It is now in the queue for this repository.

@scottmcm
Copy link
Member

Ha, just a couple seconds apart on the r+ing

@GuillaumeGomez GuillaumeGomez mentioned this pull request Apr 18, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 18, 2023
@bors
Auto merge of rust-lang#110492 - GuillaumeGomez:rollup-n4tpbl4, r=Gui…
4e46301 
…llaumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#110417 (Spelling compiler)
 - rust-lang#110441 (5 little typos)
 - rust-lang#110485 (Fix bootstrap locking)
 - rust-lang#110488 (Add a failing rustdoc-ui test for public infinite recursive type)
 - rust-lang#110490 (Bump `download-ci-llvm-stamp` for loong support)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e6b6073 into rust-lang:master Apr 18, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 18, 2023
@kadiwa4 kadiwa4 deleted the typos branch April 18, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noratrieb Noratrieb Noratrieb left review comments

@scottmcm scottmcm scottmcm left review comments

Assignees

@scottmcm scottmcm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
6 participants
@kadiwa4 @rustbot @scottmcm @bors @thomcc @Noratrieb