Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling misc #110424

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Spelling misc #110424

merged 1 commit into from
Apr 20, 2023

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Apr 16, 2023

These two files seem to be fairly distinct from everything else.

That said, if this project doesn't like changing changelogs, I'm happy to drop the changes to RELEASES.md

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Apr 16, 2023
@KittyBorgX
Copy link
Member

@jsoref
It's metioned in another PR of yours too but i'll mention it here, just to make it easier for you to keep track and to make it easier for the reviewer to approve. Can you squash all your commits into one commit?

@jsoref
Spelling misc
0100678 
* environment
* nonexistent
* potential
* prefixes
* stabilization
* suffixes
* use

Signed-off-by: Josh Soref <[email protected]>
@jsoref
Copy link
Contributor Author

jsoref commented Apr 17, 2023

Sure. I just tend to expect some pushback on individual changes, but if there isn't any, I don't mind squashing -- if there is, it's really much harder to unscramble an egg...

@KittyBorgX
Copy link
Member

Ah I see. I left a comment after I went through the changes 😅
In my opinion, there weren't any big time changes that required reviewer's discretion so I left a comment to make it easier for the reviewer :)

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

I'll approve this and the other PR in my queue (thanks!) but in general we prefer to avoid widespread spelling/typo fixes, as they're usually not too impactful in readability and yet can take significant reviewer time. (As mentioned in #110392 (comment)).

@bors
Copy link
Contributor

bors commented Apr 19, 2023

📌 Commit 0100678 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2023
@JohnTitor JohnTitor mentioned this pull request Apr 20, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 20, 2023
@bors
Auto merge of rust-lang#110585 - JohnTitor:rollup-gfffoiv, r=JohnTitor
13fc33e 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#102341 (Implement `Neg` for signed non-zero integers.)
 - rust-lang#110424 (Spelling misc)
 - rust-lang#110448 (cmp doc examples improvements)
 - rust-lang#110516 (bootstrap: Update linux-raw-sys to 0.3.2)
 - rust-lang#110548 (Make `impl Debug for Span` not panic on not having session globals.)
 - rust-lang#110554 (`deny(unsafe_op_in_unsafe_fn)` in `rustc_data_structures`)
 - rust-lang#110575 (fix lint regression in `non_upper_case_globals`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 41a2fb2 into rust-lang:master Apr 20, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 20, 2023
@jsoref jsoref deleted the spelling-misc branch April 20, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jsoref @rustbot @KittyBorgX @Mark-Simulacrum @bors