Add additional information to note for referencing packed field diagnostic #110213

bindsdev · 2023-04-12T03:24:22Z

Addresses #110199

…ostic

rustbot · 2023-04-12T03:24:29Z

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-04-12T03:24:32Z

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

TaKO8Ki · 2023-04-12T10:02:55Z

Could you fix some unit test stderr files?

compiler-errors · 2023-04-26T21:17:48Z

compiler/rustc_mir_transform/src/check_packed_ref.rs

@@ -56,8 +56,9 @@ impl<'tcx> Visitor<'tcx> for PackedRefChecker<'_, 'tcx> {
                        "reference to packed field is unaligned"
                    )
                    .note(


This should probably be broken up into several notes, e.g.

packed structs are only aligned by one byte, and many modern architectures penalize unaligned field accesses

creating a misaligned reference is undefined behavior (even if that ...

I tried to phrase my suggestion to avoid these periods in the note, because they don't match the style of other notes. Can you rephrase this to be more like what I suggested here?

Oh yeah, I totally missed that one. Apologies.

compiler-errors

Please see my follow-up comment about the phrasing of the note message. Also, Merge commits are not allowed in PRs, and this really should be squashed into one commit.

compiler-errors · 2023-04-28T05:11:10Z

compiler/rustc_mir_transform/src/check_packed_ref.rs

@@ -56,8 +56,9 @@ impl<'tcx> Visitor<'tcx> for PackedRefChecker<'_, 'tcx> {
                        "reference to packed field is unaligned"
                    )
                    .note(


I tried to phrase my suggestion to avoid these periods in the note, because they don't match the style of other notes. Can you rephrase this to be more like what I suggested here?

- Remove unrelated code - Use a local dir path

(formally `...inaccessbile...`)

It exists and is pretty cool. More people should use it.

This moves more of the internal/lang items into the private rt module.

If opening a directory with `FILE_LIST_DIRECTORY` access fails then we should try opening without requesting that access. We may still be able to delete it if it's empty or a link.

Signed-off-by: cui fliter <[email protected]>

rustbot · 2023-04-29T01:04:27Z

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred in src/tools/rust-analyzer

cc @rust-lang/rust-analyzer

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

bindsdev · 2023-04-29T01:05:12Z

I messed something up. I am going to reopen the PR.

add additional information to note for referencing packed field diagn…

40a7ec9

…ostic

rustbot assigned TaKO8Ki Apr 12, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 12, 2023

fix failing tests

22cd28e

compiler-errors reviewed Apr 26, 2023

View reviewed changes

bindsdev added 2 commits April 27, 2023 22:10

Merge branch 'master' into improve-packed-struct-ref-diagnostic

0584ab6

split note into two

599e6e6

compiler-errors requested changes Apr 28, 2023

View reviewed changes

WaffleLapkin and others added 18 commits April 28, 2023 19:59

Fix ui/io-checks/inaccessbile-temp-dir.rs test

0282d91

Improve non-ice-error-on-worker-io-fail.rs test

39758cf

- Remove unrelated code - Use a local dir path

fix typo in the inaccessible-temp-dir test name

49ec217

(formally `...inaccessbile...`)

ignore failing test on arm

636df41

configure --set support list as arguments

b44b55c

add test

d40b292

Fix help message of option for checking List

55de158

fix bug in set args

5591c2d

Document const {} syntax for std::thread_local.

a0ea9c4

It exists and is pretty cool. More people should use it.

test that we format the panic message only once

6bb8edb

refactor(docs): remove macro resolution fallback

1b08317

test(doc): no fallback marco resolution

dca2dc1

nits

1ae1888

Remove unused std::sys_common::thread_local_key::Key.

8ecf4f0

Update test.

f339519

Skip rustc version detection on macOS

255b145

Comment round rust-lang#1

27c3968

Remove "V1" from ArgumentsV1 and FlagsV1.

5b3ac7a

m-ou-se and others added 16 commits April 28, 2023 19:59

Restructure std::fmt::rt a bit.

5c12ba3

This moves more of the internal/lang items into the private rt module.

Update tests.

f85d1ad

Update miri test.

a1461c2

pub -> pub(super).

0f23cd6

Migrate trivially translatable rustc_parse diagnostics

725b5ae

rustdoc: rebind bound vars to type-outlives predicates

73fd14e

Add invalid_macro_export_arguments to built-in macro list

ee2fe37

Sort hardwired lints

58e55a6

Add a few more missing lints

f293dcc

remove_dir_all: delete directory with fewer perms

9a86cc9

If opening a directory with `FILE_LIST_DIRECTORY` access fails then we should try opening without requesting that access. We may still be able to delete it if it's empty or a link.

Fix unavailable url

1594d69

Signed-off-by: cui fliter <[email protected]>

Add some MIR pre-codegen tests for slice indexing

5e051e4

Also use mir::Offset for pointer add

bb56b0d

Update awscli

f624c6f

repr attribute needs to be stored to be used in doc(inline) by rustdoc

9a65a20

Add regression test for rust-lang#110698

a692173

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Apr 29, 2023

bindsdev closed this Apr 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add additional information to note for referencing packed field diagnostic #110213

Add additional information to note for referencing packed field diagnostic #110213

bindsdev commented Apr 12, 2023

rustbot commented Apr 12, 2023

rustbot commented Apr 12, 2023

TaKO8Ki commented Apr 12, 2023

compiler-errors Apr 26, 2023

compiler-errors Apr 28, 2023

bindsdev Apr 28, 2023

compiler-errors left a comment

compiler-errors Apr 28, 2023

rustbot commented Apr 29, 2023

bindsdev commented Apr 29, 2023

Add additional information to note for referencing packed field diagnostic #110213

Add additional information to note for referencing packed field diagnostic #110213

Conversation

bindsdev commented Apr 12, 2023

rustbot commented Apr 12, 2023

rustbot commented Apr 12, 2023

TaKO8Ki commented Apr 12, 2023

compiler-errors Apr 26, 2023

Choose a reason for hiding this comment

compiler-errors Apr 28, 2023

Choose a reason for hiding this comment

bindsdev Apr 28, 2023

Choose a reason for hiding this comment

compiler-errors left a comment

Choose a reason for hiding this comment

compiler-errors Apr 28, 2023

Choose a reason for hiding this comment

rustbot commented Apr 29, 2023

bindsdev commented Apr 29, 2023