Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symbol cleanups #110175

Merged
merged 4 commits into from
Apr 12, 2023
Merged

Symbol cleanups #110175

merged 4 commits into from
Apr 12, 2023

Commits on Apr 11, 2023

  1. Introduce Region::get_name_or_anon. 

    For a common pattern.
    @nnethercote
    nnethercote committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    5716ae6 View commit details
    Browse the repository at this point in the history

  2. Fix RegionCtxt::preference_value. 

    There's a bad pattern matching confusion present in this function.
`_anon` gets assigned to, and then `_anon` is used as an unbound
variable in the pattern, which is unrelated to the first `_anon`.
If the `_anon` didn't start with `_` the compiler would give warnings.

This was introduced in rust-lang#104239.

I have rewritten the function to remove the confusion and preserve the
existing behaviour. This seems safest, because the original intent is
not clear.
    @nnethercote
    nnethercote committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    1eb5390 View commit details
    Browse the repository at this point in the history

  3. Use the existing static and env symbols instead of interning.

    @nnethercote
    nnethercote committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    bd7f301 View commit details
    Browse the repository at this point in the history

  4. Add sym::anon.

    @nnethercote
    nnethercote committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    7975779 View commit details
    Browse the repository at this point in the history