-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate most of rustc_builtin_macros
to diagnostic impls
#110092
Conversation
r? @TaKO8Ki (rustbot has picked a reviewer for you, use r? to override) |
e4c55da
to
64d2234
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment
48260ef
to
37b1f96
Compare
Co-authored-by: Joe ST <[email protected]> Co-authored-by: Michael Goulet <[email protected]>
37b1f96
to
64f7597
Compare
|
ty @bors delegate+ r=me when green |
✌️ @clubby789 can now approve this pull request |
@bors r=compiler-errors |
☀️ Test successful - checks-actions |
Finished benchmarking commit (45749b2): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
…henkov Remove accidental comment Left this in in rust-lang#110092 while debugging, thanks to `@WaffleLapkin` for spotting
cc #100717
This is a couple of days work, but I decided to stop for now before the PR becomes too big. There's around 50 unresolved failures when
rustc::untranslatable_diagnostic
is denied, which I'll finish addressing once this PR goes thtoughA couple of outputs have changed, but in all instances I think the changes are an improvement/are more consistent with other diagnostics (although I'm happy to revert any which seem worse)