Fix building compiling on OS X 10.9 #10970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apple replaced gcc with clang, but kept around a stub gcc to call clang. This adds a check in `configure` to detect when gcc is really clang, and switch to using clang in this situation. Closes rust-lang#10811.
bors
added a commit
that referenced
this pull request
Dec 15, 2013
This modifies the `configure` to set `CFG_ENABLE_CLANG=1` if `gcc` is actually `clang`. This is needed because OS X's clang enables warning on unused command line arguments. Our build system suppresses this by default, but when `CFG_ENABLE_CLANGE=0`, we do not. This causes one of the tests to fail. This patch changes rust to directly use clang, which fixes the build failure. Closes #10811
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 14, 2023
new lint: `read_line_without_trim` This adds a new lint that checks for calls to `Stdin::read_line` with a reference to a string that is then attempted to parse into an integer type without first trimming it, which is always going to fail at runtime. This is something that I've seen happen a lot to beginners, because it's easy to run into when following the example of chapter 2 in the book where it shows how to program a guessing game. It would be nice if we could point beginners to clippy and tell them "let's see what clippy has to say" and have clippy explain to them why it fails 👀 I think this lint can later be "generalized" to work not just for `Stdin` but also any `BufRead` (which seems to be where the guarantee about the trailing newline comes from) and also, matching/comparing it to a string slice that doesn't end in a newline character (e.g. `input == "foo"` is always going to fail) changelog: new lint: [`read_line_without_trim`]
matthiaskrgr
pushed a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 11, 2024
…tic, r=Veykril feat: Add diagnostic with fix to replace trailing `return <val>;` with `<val>` Works for functions and closures. Ignores desugared return expressions (e.g. from desugared try operators). Fixes: rust-lang#10970 Completes: rust-lang#11020
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 27, 2024
…=dswij
[`read_line_without_trim`]: detect string literal comparison and `.ends_with()` calls
This lint now also realizes that a comparison like `s == "foo"` and calls such as `s.ends_with("foo")` will fail if `s` was initialized by a call to `Stdin::read_line` (because of the trailing newline).
changelog: [`read_line_without_trim`]: detect string literal comparison and `.ends_with()` calls
r? `@giraffate` assigning you because you reviewed rust-lang#10970 that added this lint, so this is kinda a followup PR ^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the
configureto setCFG_ENABLE_CLANG=1ifgccis actuallyclang. This is needed because OS X's clang enables warning on unused command line arguments. Our build system suppresses this by default, but whenCFG_ENABLE_CLANGE=0, we do not. This causes one of the tests to fail. This patch changes rust to directly use clang, which fixes the build failure.Closes #10811