Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit JSON output for the building of bootstrap itself #107873

Merged
merged 1 commit into from
Feb 11, 2023
Merged

Emit JSON output for the building of bootstrap itself #107873

merged 1 commit into from
Feb 11, 2023

Conversation

zephaniahong
Copy link
Contributor

@zephaniahong zephaniahong commented Feb 10, 2023 •
edited
Loading

Fixes #107832 .
Main changes are from line 792 onwards. Other changes are due to the flake8 formatter. Let me know if I should not use the formatter.

@rustbot
Copy link
Collaborator

rustbot commented Feb 10, 2023

r? @albertlarsan68

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 10, 2023
@zephaniahong zephaniahong marked this pull request as ready for review February 10, 2023 07:14
@albertlarsan68
Copy link
Member

I think the formatting should be done in another PR, to have a dedicated place to discuss it.
The title would be more "Emit JSON output for the building of bootstrap itself", but no blocker on that.
Otherwise LGTM.
r=me with the formatting changes removed and commit title changed if you want.

@albertlarsan68 albertlarsan68 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2023
@zephaniahong zephaniahong changed the title emit json output from ./x.py check --json-output even if check fails Emit JSON output for the building of bootstrap itself Feb 11, 2023
@zephaniahong
Copy link
Contributor Author

zephaniahong commented Feb 11, 2023 •
edited
Loading

@albertlarsan68

I think the formatting should be done in another PR, to have a dedicated place to discuss it. The title would be more "Emit JSON output for the building of bootstrap itself", but no blocker on that. Otherwise LGTM. r=me with the formatting changes removed and commit title changed if you want.

Sorry not quite sure what 'r=me' means so I'll just tag you.

@rustbot
Copy link
Collaborator

rustbot commented Feb 11, 2023

Could not assign reviewer from: albertlarsan68.
User(s) albertlarsan68 are either the PR author or are already assigned, and there are no other candidates.
Use r? to specify someone else to assign.

@jyn514
Copy link
Member

jyn514 commented Feb 11, 2023

@zephaniahong out of curiosity, have you tested whether this fixes rust-analyzer on bootstrap when it doesn't compile?

@jyn514
Copy link
Member

jyn514 commented Feb 11, 2023

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 11, 2023
@zephaniahong
Copy link
Contributor Author

zephaniahong commented Feb 11, 2023 •
edited
Loading

@jyn514 Yupp! Works for me😊

@zephaniahong
Copy link
Contributor Author

@bors r=albertlarsan68

@bors
Copy link
Contributor

bors commented Feb 11, 2023

@zephaniahong: 🔑 Insufficient privileges: Not in reviewers

@albertlarsan68
Copy link
Member

Thanks for your PR!
@bors r+

@bors
Copy link
Contributor

bors commented Feb 11, 2023

📌 Commit 1057e21 has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 11, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 11, 2023
@bors
Auto merge of rust-lang#107928 - matthiaskrgr:rollup-qnn380r, r=matth…
2b3f260 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#107657 (Add only modified subcommand for compiletest)
 - rust-lang#107864 (rustdoc: clean up `write!` calls with less stuttering)
 - rust-lang#107873 (Emit JSON output for the building of bootstrap itself)
 - rust-lang#107895 (remove redundant clones)
 - rust-lang#107897 (Reexported macros docs)
 - rust-lang#107909 (rustdoc: remove redundant `if s.is_empty()` from `find_testable_code`)
 - rust-lang#107912 (rustdoc: Don't resolve link to field on different variant)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 420e756 into rust-lang:master Feb 11, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertlarsan68 albertlarsan68

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.

x check --json-output doesn't use JSON output for building bootstrap itself
5 participants
@zephaniahong @rustbot @albertlarsan68 @jyn514 @bors