rustdoc: change the +/- icons #107658
rustdoc: change the +/- icons #107658
Conversation
|
r? @notriddle (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
|
Personally, I'm okay with this, but I'd like the toggle-all-docs button in the top right corner to be redesigned as well. It should probably also go through FCP before merging it. |
|
I also like the new icon and I agree that we need an FCP for it. Can you provide screenshots for the other themes as well please? |
|
(nit) It looks like for the the methods and description dropdown, the arrow appears to be slightly below the line of text. Compared to function & type items where it's centered
(also nit) A slight size reduction to about 90% of line height might look good, just to reduce its prominence compared to the text it's associated with |
|
The toggle-all-docs button now has a new icon. I also made the other icons a little smaller and aligned them properly. |
|
I'm not a big fan of the new "toggle all" button. At least the previous was somehow explicit about what it was doing. The new one is more beautiful but more difficult to decipher (imo). |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Re: the toggle button, I think the most explicit thing would be to replace the icon with a word - |
|
I like @jsha's Idea. Looks great and is very explicit.
|
|
I like it too. Should we use the same color as for the |
|
I feel like the gray looks a little better. Also, the color of
|
|
But grey is associated with "disabled item". So I don't think it's a good idea to keep as is. |
|
Good Point. We could set it to the main color
|
|
A border around it might also work
|
|
|
maybe something like that?
|
|
The arrows are making me think it can be downloaded. As for the |
|
☔ The latest upstream changes (presumably #108863) made this pull request unmergeable. Please resolve the merge conflicts. |
|
If this has been decided against, it probably makes sense to post an update to #59851. But maybe Just making the + and - bold would be enough to address the original listed "difficult to tell apart" concern? |
This is a continuation of rust-lang#107658 and rust-lang#59851, making the toggles consistent with other buttons, instead of looking like syntax. The tactics to improve the look of these controls: * When the toggle is expanded, the minus sign remains as dark as before, but the border is lighter. The plus sign has a border that's the same color as the label (black, on the default theme). This makes expansion buttons more prominent, easier to tell apart from collapse buttons. * The plus sign is slightly taller than wide, also to make it easier to tell apart from the minus sign. * The use of crispEdges has to get a bit strategic to make this come out right. I've tested it on Firefox, Safari, and Chromium, but it's a bit hard to be sure it works right on all setups. * Does anybody know some trick to do crispEdges on only the X axis, while still allowing antialiasing on the Y? * The "toggle all" button is modeled after the Help and Settings buttons, with a matching border, width, and +/− label.
This is a continuation of rust-lang#107658 and rust-lang#59851, making the toggles consistent with other buttons, instead of looking like syntax. The tactics to improve the look of these controls: * When the toggle is expanded, the minus sign remains as dark as before, but the border is lighter. The plus sign has a border that's the same color as the label (black, on the default theme). This makes expansion buttons more prominent, easier to tell apart from collapse buttons. * The plus sign is slightly taller than wide, also to make it easier to tell apart from the minus sign. * The use of crispEdges has to get a bit strategic to make this come out right. I've tested it on Firefox, Safari, and Chromium, but it's a bit hard to be sure it works right on all setups. * Does anybody know some trick to do crispEdges on only the X axis, while still allowing antialiasing on the Y? * The "toggle all" button is modeled after the Help and Settings buttons, with a matching border, width, and +/− label.
This is a continuation of rust-lang#107658 and rust-lang#59851, making the toggles consistent with other buttons, instead of looking like syntax. The tactics to improve the look of these controls: * When the toggle is expanded, the minus sign remains as dark as before, but the border is lighter. The plus sign has a border that's the same color as the label (black, on the default theme). This makes expansion buttons more prominent, easier to tell apart from collapse buttons. * The plus sign is slightly taller than wide, also to make it easier to tell apart from the minus sign. * The use of crispEdges has to get a bit strategic to make this come out right. I've tested it on Firefox, Safari, and Chromium, but it's a bit hard to be sure it works right on all setups. * Does anybody know some trick to do crispEdges on only the X axis, while still allowing antialiasing on the Y? * The "toggle all" button is modeled after the Help and Settings buttons, with a matching border, width, and +/− label.
The
[+]and[-]icons to expand/collapse parts of the documentation are really difficult to tell apart. This tries to replace them with something simpler.Old
New
Demo: https://host-7e0a2.web.app/sample-2/std/iter/trait.Iterator.html
Also discussed here: #59851