ast: Optimize list and value extraction primitives for attributes

[petrochenkov]

It's not necessary to convert the whole attribute into a meta item to extract something specific.

[rustbot]

r? @eholk

(rustbot has picked a reviewer for you, use r? to override)

[petrochenkov]

@bors try @rust-timer queue

[bors]

⌛ Trying commit a9c8a5c with merge 2af8a52b328ed208751d49ed4a2a2b2f1e35f328...

[bors]

☀️ Try build successful - checks-actions
Build commit: 2af8a52b328ed208751d49ed4a2a2b2f1e35f328 (2af8a52b328ed208751d49ed4a2a2b2f1e35f328)

[rust-timer]

Finished benchmarking commit (2af8a52b328ed208751d49ed4a2a2b2f1e35f328): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.2%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[2.5%, 2.5%]	1
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.3%	[-2.3%, -2.3%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

[petrochenkov]

r? @nnethercote

[petrochenkov]

"Non-relevant results" are interesting here, especially if you select doc or check.

[nnethercote]

@bors r+

[bors]

📌 Commit a9c8a5c has been approved by nnethercote

It is now in the queue for this repository.

[bors]

⌛ Testing commit a9c8a5c with merge a94b9fd...

[bors]

☀️ Test successful - checks-actions
Approved by: nnethercote
Pushing a94b9fd to master...

[rust-timer]

Finished benchmarking commit (a94b9fd): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.2%	[-0.2%, -0.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.2%	[-0.2%, -0.2%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.