Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make blame spans better for impl wfcheck #106785

Merged
merged 3 commits into from
Jan 13, 2023
Merged

Make blame spans better for impl wfcheck #106785

merged 3 commits into from
Jan 13, 2023

Conversation

compiler-errors
Copy link
Member

r? types

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 12, 2023
@compiler-errors compiler-errors mentioned this pull request Jan 12, 2023
Merged
@estebank
Copy link
Contributor

r=me after fixing test

@compiler-errors
Copy link
Member Author

@bors r=estebank

@bors
Copy link
Contributor

bors commented Jan 13, 2023

📌 Commit 5924c25 has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2023
@JohnTitor JohnTitor mentioned this pull request Jan 13, 2023
Merged
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 13, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 13, 2023
@matthiaskrgr
Rollup merge of rust-lang#106785 - compiler-errors:better-impl-wf-spa…
bfcf0c4 
…ns, r=estebank

Make blame spans better for impl wfcheck

r? types
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 13, 2023
@bors
Auto merge of rust-lang#106801 - JohnTitor:rollup-xqkraw0, r=JohnTitor
5ca6f7d 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#106608 (Render missing generics suggestion verbosely)
 - rust-lang#106716 ([RFC 2397] Deny incorrect locations)
 - rust-lang#106754 (Rename `Ty::is_ty_infer` -> `Ty::is_ty_or_numeric_infer`)
 - rust-lang#106782 (Ignore tests move in git blame)
 - rust-lang#106785 (Make blame spans better for impl wfcheck)
 - rust-lang#106791 (Fix ICE formatting)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5adc7a5 into rust-lang:master Jan 13, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 13, 2023
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jan 27, 2023
@bors
Auto merge of rust-lang#106801 - JohnTitor:rollup-xqkraw0, r=JohnTitor
ac95db6 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#106608 (Render missing generics suggestion verbosely)
 - rust-lang#106716 ([RFC 2397] Deny incorrect locations)
 - rust-lang#106754 (Rename `Ty::is_ty_infer` -> `Ty::is_ty_or_numeric_infer`)
 - rust-lang#106782 (Ignore tests move in git blame)
 - rust-lang#106785 (Make blame spans better for impl wfcheck)
 - rust-lang#106791 (Fix ICE formatting)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@compiler-errors compiler-errors deleted the better-impl-wf-spans branch August 11, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spastorino spastorino

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @estebank @bors @spastorino @rustbot