Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support unit tests for jsondoclint #104944

Merged
merged 2 commits into from
Nov 27, 2022
Merged

Support unit tests for jsondoclint #104944

merged 2 commits into from
Nov 27, 2022

Conversation

aDotInTheVoid
Copy link
Member

r? @ghost

@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 26, 2022
@aDotInTheVoid
Copy link
Member Author

Fails as expected

---- json_find::tests::should_fail stdout ----
thread 'json_find::tests::should_fail' panicked at 'assertion failed: `(left == right)`
  left: `true`,
 right: `false`', src/tools/jsondoclint/src/json_find/tests.rs:3:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    json_find::tests::should_fail

(not sure why rust-log-analyzer didn't comment)

@aDotInTheVoid aDotInTheVoid marked this pull request as ready for review November 26, 2022 16:25
@aDotInTheVoid
Copy link
Member Author

r? @jyn514

As jsondoclint gets more complex, I'd like to be able to have some assurances about it's behaviour, and the rustdoc-json suite can can't test that errors are caught, only that they arn't.

@aDotInTheVoid aDotInTheVoid changed the title [DRAFT] Support unit tests for jsondoclint Support unit tests for jsondoclint Nov 26, 2022
@jyn514
Copy link
Member

jyn514 commented Nov 26, 2022

Seems useful.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 26, 2022

📌 Commit 09818a8 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 27, 2022
@matthiaskrgr
Rollup merge of rust-lang#104944 - aDotInTheVoid:jsondoclint-unit-tes…
95e3ba6 
…ts, r=jyn514

Support unit tests for jsondoclint

r? `@ghost`
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 27, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 27, 2022
@matthiaskrgr
Rollup merge of rust-lang#104944 - aDotInTheVoid:jsondoclint-unit-tes…
13fe0aa 
…ts, r=jyn514

Support unit tests for jsondoclint

r? ``@ghost``
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 27, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 27, 2022
@matthiaskrgr
Rollup merge of rust-lang#104944 - aDotInTheVoid:jsondoclint-unit-tes…
2466992 
…ts, r=jyn514

Support unit tests for jsondoclint

r? ```@ghost```
This was referenced Nov 27, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 27, 2022
@bors
Auto merge of rust-lang#104983 - matthiaskrgr:rollup-018sk73, r=matth…
1eb62b1 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#95836 (Use `rust_out{exe_suffix}` for doctests)
 - rust-lang#104882 (notify lcnr on changes to `ObligationCtxt`)
 - rust-lang#104892 (Explain how to get the discriminant out of a `#[repr(T)] enum` with payload)
 - rust-lang#104917 (Allow non-org members to label `requires-debug-assertions`)
 - rust-lang#104931 (Pretty-print generators with their `generator_kind`)
 - rust-lang#104934 (Remove redundant `all` in cfg)
 - rust-lang#104944 (Support unit tests for jsondoclint)
 - rust-lang#104946 (rustdoc: improve popover focus handling JS)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e3165a3 into rust-lang:master Nov 27, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jyn514 jyn514

Labels
A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
4 participants
@aDotInTheVoid @jyn514 @bors @rustbot