Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #103391

Closed
wants to merge 15 commits into from
Closed

Commits on Oct 2, 2022

  1. Configuration menu
    Copy the full SHA
    64e7fd9 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. Configuration menu
    Copy the full SHA
    2cc4a0a View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Copy of rust-lang#102941.

    finnbear committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    f81cd87 View commit details
    Browse the repository at this point in the history
  2. Put fn in the right place.

    finnbear committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    4f44d62 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. Configuration menu
    Copy the full SHA
    9b67910 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cc1407f View commit details
    Browse the repository at this point in the history
  3. Reduce false positives in msys2 detection

    This checks that:
    
    * the handle is a pipe
    * the pipe's file name starts with "msys-" or "cygwin-" rather than looking in the full path.
    ChrisDenton committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    d7b0bcb View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2022

  1. Only apply ProceduralMasquerade hack to older versions of rental

    The latest version of `rental` (v0.5.6) contains a fix that allows it to
    compile without relying on the pretty-print back-compat hack.
    
    Hopefully, there are no longer any crates relying on the affected
    versions of the (much less popular) `procedural-masquerade` crate. This
    should allow us to target the pretty-print back-compat hack specifically
    to older versions of `rental`, and specifically mention upgrading to
    `rental` v0.5.6 in the lint message.
    Aaron1011 committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    10dad22 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#94063 - Aaron1011:pretty-print-rental, r=lcnr

    Only apply `ProceduralMasquerade` hack to older versions of `rental`
    
    The latest version of `rental` (v0.5.6) contains a fix that allows it to
    compile without relying on the pretty-print back-compat hack.
    
    Hopefully, there are no longer any crates relying on the affected
    versions of the (much less popular) `procedural-masquerade` crate. This
    should allow us to target the pretty-print back-compat hack specifically
    to older versions of `rental`, and specifically mention upgrading to
    `rental` v0.5.6 in the lint message.
    Dylan-DPC authored Oct 22, 2022
    Configuration menu
    Copy the full SHA
    fbe36a8 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#102602 - WaffleLapkin:linty_action, r=estebank

    Slightly tweak comments wrt `lint_overflowing_range_endpoint`
    
    From the review: rust-lang#101986 (comment)
    
    It _seemed_ that the lint was not emitted when the `if` check failed, but _actually_ this happens already in a special case and the lint is emitted outside of this function, if this function doesn't. I've cleared up the code/comments a bit, so it's more obvious :)
    
    r? `@estebank`
    Dylan-DPC authored Oct 22, 2022
    Configuration menu
    Copy the full SHA
    f7bf5cd View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#103122 - ouz-a:mir-technical-debt, r=oli-obk

    Remove misc_cast and validate types when casting
    
    Continuing our work in rust-lang#102675
    
    r? `@oli-obk`
    Dylan-DPC authored Oct 22, 2022
    Configuration menu
    Copy the full SHA
    24d17ef View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#103190 - fmease:rustdoc-render-bounds-of-cr…

    …oss-crate-gat-params, r=GuillaumeGomez
    
    rustdoc: render bounds of cross-crate GAT params
    
    Follow-up to rust-lang#102439.
    Render the trait bounds of type parameters of cross-crate (generic) associated types.
    
    ```@rustbot``` label T-rustdoc A-cross-crate-reexports
    r? ```@GuillaumeGomez```
    Dylan-DPC authored Oct 22, 2022
    Configuration menu
    Copy the full SHA
    6529ccc View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#103280 - finnbear:impl_string_leak_2, r=jos…

    …htriplett
    
    (rust-lang#102929) Implement `String::leak` (attempt 2)
    
    Implementation of `String::leak` (rust-lang#102929)
    
    ACP: rust-lang/libs-team#109
    
    Supersedes rust-lang#102941 (see previous reviews there)
    
    `@rustbot` label +T-libs-api -T-libs
    Dylan-DPC authored Oct 22, 2022
    Configuration menu
    Copy the full SHA
    9e8a564 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#103329 - saethlin:nonnull-precondition, r=t…

    …homcc
    
    Add a forgotten check for NonNull::new_unchecked's precondition
    
    Looks like I forgot this function a while ago in rust-lang#92686
    
    r? `@thomcc`
    Dylan-DPC authored Oct 22, 2022
    Configuration menu
    Copy the full SHA
    b614419 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#103360 - ChrisDenton:isterm-filetype, r=thomcc

    Reduce false positives in msys2 detection
    
    Currently msys2 will be detected by getting the file path and looking to see if it contains the substrings "msys-" and "-ptr" (or "cygwin-" and "-pty"). This risks false positives, especially with filesystem files and if `GetFileInformationByHandleEx` returns a [full path](https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/ntifs/nf-ntifs-ntqueryinformationfile#remarks).
    
    This PR adds a check to see if the handle is a pipe before doing the substring search. Additionally, for "msys2-" or "cygwin-" it only checks if the file name starts with the substring rather than looking at the whole path.
    Dylan-DPC authored Oct 22, 2022
    Configuration menu
    Copy the full SHA
    da0f4eb View commit details
    Browse the repository at this point in the history