Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make is_ascii_hexdigit branchless #103024

Closed
wants to merge 4 commits into from
Closed

Make is_ascii_hexdigit branchless #103024

wants to merge 4 commits into from

Commits on Oct 13, 2022

  1. Make is_ascii_hexdigit branchless 

    Bitwise-or with 0x20 before checking if character in range a-z avoids
need to check if it is in range A-Z. This makes the generated code
shorter and faster.
    @GKFX
    GKFX committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    acb42cf View commit details
    Browse the repository at this point in the history

  2. Fix typo in range

    @GKFX
    GKFX committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    5b624ac View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. Clarify comment and use character literals in char::is_ascii_hexdigit

    @GKFX
    GKFX committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    f624897 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2022

  1. Fully optimize is_ascii_hexdigit by hand 

    This should compile to the same thing as the previous commit (at a suitable optimization level) but makes it very clear what is intended.
    @GKFX
    GKFX committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    8d1d17f View commit details
    Browse the repository at this point in the history