Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[work in progress] Upgrade to musl 1.2.3 #102891

Closed
wants to merge 6 commits into from
Closed

[work in progress] Upgrade to musl 1.2.3 #102891

wants to merge 6 commits into from

Conversation

wesleywiser
Copy link
Member

This PR is a companion PR to rust-lang/libc#2088 which updates libc's bindings to support musl 1.2.3. In this PR, we begin building & distributing musl targets with 1.2.3 and update the libc dependency to point to the new version (as the other PR has not yet been merged, I've pointed libc at my fork for now).

With this PR, we should be able to do a crater run of the musl upgrade.

r? @ghost

@rustbot rustbot added T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 10, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 10, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@wesleywiser wesleywiser force-pushed the musl_upgrade branch 4 times, most recently from 8dad4d7 to ca13b68 Compare October 10, 2022 18:27
@wesleywiser
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Oct 10, 2022

⌛ Trying commit ca13b688e8ff91d230ea632e011eb9f14cc0aae4 with merge 7a25e4df4d743fea03e37eda7be5b06e1f5a1fe8...

@bors
Copy link
Contributor

bors commented Oct 10, 2022

💔 Test failed - checks-actions

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 10, 2022
@rustbot

This comment was marked as outdated.

Sign in to view
@wesleywiser
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Oct 10, 2022

⌛ Trying commit d7ff3c304b807cb02e4e229d61a1aadd3710fb6d with merge f3364a388441ef6815346941a29f8033c29dd3f6...

@bors
Copy link
Contributor

bors commented Oct 10, 2022

💔 Test failed - checks-actions

@wesleywiser
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Oct 10, 2022

⌛ Trying commit 5aee412d61871327208a1568064504feb22f34cd with merge e392e7b50913d5cb6e2c08d70cdeb72e56d289f9...

@bors
Copy link
Contributor

bors commented Oct 10, 2022

☀️ Try build successful - checks-actions
Build commit: e392e7b50913d5cb6e2c08d70cdeb72e56d289f9 (e392e7b50913d5cb6e2c08d70cdeb72e56d289f9)

1 similar comment
@bors
Copy link
Contributor

bors commented Oct 10, 2022

☀️ Try build successful - checks-actions
Build commit: e392e7b50913d5cb6e2c08d70cdeb72e56d289f9 (e392e7b50913d5cb6e2c08d70cdeb72e56d289f9)

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@wesleywiser
Copy link
Member Author

Starting with a small crater run just to make sure things are working correctly...

@craterbot run mode=build-and-test crates=top-100 name=musl_upgrade_test start=try#8dae881ac166f8debe04e17604ebbe2ab47083fd+target=i686-unknown-linux-musl end=try#e392e7b50913d5cb6e2c08d70cdeb72e56d289f9+target=i686-unknown-linux-musl+patch=libc=https://github.com/wesleywiser/libc=musl-1.2

@craterbot
Copy link
Collaborator

👌 Experiment musl_upgrade_test created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 11, 2022
@craterbot
Copy link
Collaborator

🚧 Experiment musl_upgrade_test is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Mark-Simulacrum
Copy link
Member

@craterbot abort

See https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/crater.20run.20for.20musl.20target

@wesleywiser
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Dec 7, 2022

⌛ Trying commit 622998e with merge 04c11acd339209418a0f193687aa4190c1b645cf...

@bors
Copy link
Contributor

bors commented Dec 7, 2022

☀️ Try build successful - checks-actions
Build commit: 04c11acd339209418a0f193687aa4190c1b645cf (04c11acd339209418a0f193687aa4190c1b645cf)

@wesleywiser
Copy link
Member Author

@craterbot run mode=build-and-test name=musl_upgrade_1_2_take3 start=try#fc4ba03ef77ca5018fb78a097d3b924d30f15bfc+target=i686-unknown-linux-musl end=try#04c11acd339209418a0f193687aa4190c1b645cf+target=i686-unknown-linux-musl+patch=libc=https://github.com/wesleywiser/libc=musl-1.2

@craterbot
Copy link
Collaborator

👌 Experiment musl_upgrade_1_2_take3 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 7, 2022
@craterbot
Copy link
Collaborator

🚧 Experiment musl_upgrade_1_2_take3 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment musl_upgrade_1_2_take3 is completed!
📊 2285 regressed and 94 fixed (249686 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Dec 8, 2022
@wesleywiser
Copy link
Member Author

@craterbot run mode=build-and-test name=musl_upgrade_1_2_take4 start=try#fc4ba03ef77ca5018fb78a097d3b924d30f15bfc+target=i686-unknown-linux-musl end=try#04c11acd339209418a0f193687aa4190c1b645cf+target=i686-unknown-linux-musl+patch=libc=https://github.com/wesleywiser/libc=musl-1.2

@craterbot
Copy link
Collaborator

👌 Experiment musl_upgrade_1_2_take4 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2022
@craterbot
Copy link
Collaborator

🚧 Experiment musl_upgrade_1_2_take4 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment musl_upgrade_1_2_take4 is completed!
📊 959 regressed and 104 fixed (250060 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Dec 14, 2022
@wesleywiser wesleywiser mentioned this pull request Jan 12, 2023
Open
@jyn514
Copy link
Member

jyn514 commented Apr 27, 2023

@wesleywiser it looks like you continued this work in #107129, so I'm going to close this PR - feel free to reopen if they're different in some way I haven't spotted.

@jyn514 jyn514 closed this Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@wesleywiser @rustbot @bors @rust-log-analyzer @craterbot @Mark-Simulacrum @jyn514