impl AsFd and AsRawFd for io::{Stdin, Stdout, Stderr}, not the sys versions

[joshtriplett]

#100892 implemented AsFd for the
sys versions, rather than for the public types. Change the
implementations to apply to the public types.

[rustbot]

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

• Stabilizing library features
• Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
• Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
• Changing public documentation in ways that create new stability guarantees
• Changing observable runtime behavior of library APIs

[rust-highfive]

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

[joshtriplett]

Noticed when trying to merge #98033

[joshtriplett]

@bors try

[bors]

⌛ Trying commit 7887b1be32b604959cb436e964c2698bfca3122c with merge c87f0b4449c495495344282b0457bd2cd7f66eb0...

[the8472]

This seems like the wrong place. For other public, os-specific types the impl AsFd lives somewhere in os::<platform> modules, not in sys. There impls in the sys modules are for the internal types.

[bors]

☀️ Try build successful - checks-actions
Build commit: c87f0b4449c495495344282b0457bd2cd7f66eb0 (c87f0b4449c495495344282b0457bd2cd7f66eb0)

[joshtriplett]

This seems like the wrong place. For other public, os-specific types the impl AsFd lives somewhere in os::<platform> modules, not in sys. There impls in the sys modules are for the internal types.

impl AsFd for stdio types lives in library/std/src/sys/unix/stdio.rs on UNIX, as well.

[the8472]

This is a bit inconsistent, e.g. AsRawFd comes from from os::fd::raw https://doc.rust-lang.org/src/std/os/fd/raw.rs.html#183-188
And the impl AsFd for File comes from os too. https://doc.rust-lang.org/src/std/os/fd/owned.rs.html#258-263

[joshtriplett]

@the8472 That would be a substantially larger reorganization, affecting multiple targets. No objections to such a reorganization, but that seems orthogonal to this bugfix.

That said, it does look like impl AsRawFd for io::Stdin would be redundant, so I'll remove that.

[the8472]

Not suggesting to fix everything. Just put the Stdio ones in the right place.

[joshtriplett]

Alright, let's hope this actually builds everywhere.

[m-ou-se]

@bors r+

[bors]

📌 Commit ef68327 has been approved by m-ou-se

It is now in the queue for this repository.