-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-add git-commit-hash file to tarballs #102610
Conversation
I think there's another place not covered by this https://github.com/rust-lang/rust/pull/100557/files#diff-2f4b08d54e680939ebd8445ceb0f27755c515e62607519819ce4caa6fc74caa6L300 in tarball.rs. Can you check? |
Hm, yeah you're right. When I tested with I can go ahead and fix that, though. I'll factor it out into a free function like the previous PR did to |
#100557 removed the `git-commit-hash` file and replaced it with `git-commit-info`. However, build-manifest relies on the `git-commit-hash` file being present, so this adds it back.
@bors r+ p=10 |
☀️ Test successful - checks-actions |
Finished benchmarking commit (33d3519): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Footnotes |
#100557 removed the
git-commit-hash
file and replaced it withgit-commit-info
. However, build-manifest relies on thegit-commit-hash
file being present, so this adds it back.r? @Mark-Simulacrum