rustdoc: remove orphaned link on array bracket #102525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jsha (or someone else) soon. Please see the contribution instructions for more information. |
rustbot
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
This is 682889f, but for arrays instead. For non-generics, this retains links to the array page, but instead of trying to link it all, it only links the length part, which distinguishes arrays from slices. For generics, the entire thing becomes a link, just like slices.
notriddle
force-pushed
the
notriddle/array-link
branch
from
5dec46a
to
598a02c
Compare
GuillaumeGomez
approved these changes
Oct 1, 2022
|
Looks good to me, thanks! I'll let @jsha take a look since it's a "style" update. |
|
Looks good to me!
… Message ID: ***@***.***>
|
|
@bors r=GuillaumeGomez,jsha rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 2, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#102195 (Improve the COPYRIGHT file) - rust-lang#102313 (Update docs so that deprecated method points to relevant method) - rust-lang#102353 (Allow passing rustix_use_libc cfg using RUSTFLAGS) - rust-lang#102405 (Remove a FIXME whose code got moved away in rust-lang#62883.) - rust-lang#102525 (rustdoc: remove orphaned link on array bracket) - rust-lang#102557 (fix issue with x.py setup running into explicit panic) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #98069, but for arrays instead.
For non-generics, this retains links to the array page, but instead of trying to link it all, it only links the length part, which distinguishes arrays from slices.
For generics, the entire thing becomes a link, just like slices.
pub fn alpha() -> &'static [u32; 1]pub fn alpha() -> &'static [u32; 1]pub fn beta<T>() -> &'static [T; 1]pub fn beta<T>() -> &'static [T; 1]