-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: remove clean::TraitWithExtraInfo
#102375
Conversation
Instead, it gathers the extra info later, when it's actually requested.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. Please see the contribution instructions for more information. |
Some changes occurred in src/librustdoc/clean/types.rs cc @camelid |
This should probably get a perf build... |
It's super cool! It's been a while we didn't clean up the @bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit a63a03d with merge 3a575109c7eeb4467ba847d3c9b28007d3de599f... |
☀️ Try build successful - checks-actions |
Queued 3a575109c7eeb4467ba847d3c9b28007d3de599f with parent 57ee5cf, future comparison URL. |
Finished benchmarking commit (3a575109c7eeb4467ba847d3c9b28007d3de599f): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
This might help with rust-lang#102375.
Instead, it gathers the extra info later, when it's actually requested.