Rollup of 8 pull requests #102234
Merged
Rollup of 8 pull requests #102234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls/alloc.rs` nicer - Use `.addr()` instead of `as`-cast - Use `add` instead of `offset` and remove some `as isize` casts by doing that - Remove some casts
in different namespaces, one public and another private.
Instead of setting them for all primary and additional IDs of the import, only set them for the binding's true ID.
This rule became redundant in 07e3f99. When `#source-sidebar` became nested below `.sidebar`, it went from being `position: fixed` to `position: static`, and according to MDN's [z-index] documentation, this means it has no effect. [z-index]: https://developer.mozilla.org/en-US/docs/Web/CSS/z-index
This rule became redundant in 07e3f99. When `#source-sidebar` became nested below `.sidebar`, it went from being `position: fixed` to `position: static`, and according to MDN's [z-index] documentation, this means it has no effect. [z-index]: https://developer.mozilla.org/en-US/docs/Web/CSS/z-index
Refactor some `std` code that works with pointer offstes This PR replaces `pointer::offset` in standard library with `pointer::add` and `pointer::sub`, [re]moving some casts and using `.addr()` while we are at it. This is a more complicated refactor than all other sibling PRs, so take a closer look when reviewing, please 😃 (though I've checked this multiple times and it looks fine). r? ````@scottmcm```` _split off from rust-lang#100746, continuation of #100822_
Fix wrongly refactored Lift impl see rust-lang#101858 (comment) r? ``@bjorn3``
resolve: Set effective visibilities for imports more precisely Instead of setting them for all primary and additional IDs of the import, only set them for the binding's true ID.
…=fee1-dead Add const_closure, Constify Try trait Adds a struct for creating const `FnMut` closures (for now just copy pasted form my [const_closure](https://crates.io/crates/const_closure) crate). I'm not sure if this way is how it should be done. The `ConstFnClosure` and `ConstFnOnceClosure` structs can probably also be entirely removed. This is then used to constify the try trait. Not sure if i should add const_closure in its own pr and maybe make it public behind a perma-unstable feature gate. cc ```@fee1-dead``` ```@rust-lang/wg-const-eval```
…, r=GuillaumeGomez
rustdoc: remove no-op CSS `#source-sidebar { z-index }`
This rule became redundant in 07e3f99. When `#source-sidebar` became nested below `.sidebar`, it went from being `position: fixed` to `position: static`, and according to MDN's [z-index] documentation, this means it has no effect.
[z-index]: https://developer.mozilla.org/en-US/docs/Web/CSS/z-index
…ivially-drop, r=oli-obk Make `ManuallyDrop` satisfy `~const Destruct`
…r=cjgillot diagnostics: avoid syntactically invalid suggestion in if conditionals Fixes rust-lang#101065
…-obk bootstrap/miri: switch to non-deprecated env var for setting the sysroot folder r? `@oli-obk`
rustbot
added
T-bootstrap
|
@bors r+ rollup=never p=8 |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: cdb76db493 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Sep 24, 2022
|
Finished benchmarking commit (6580010): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
stdcode that works with pointer offstes #100823 (Refactor somestdcode that works with pointer offstes)#source-sidebar { z-index }#102203 (rustdoc: remove no-op CSS#source-sidebar { z-index })ManuallyDropsatisfy~const Destruct#102204 (MakeManuallyDropsatisfy~const Destruct)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup