Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constify slice.split_at_mut(_unchecked) #101800

Merged
merged 1 commit into from
Sep 25, 2022
Merged

Constify slice.split_at_mut(_unchecked) #101800

merged 1 commit into from
Sep 25, 2022

Conversation

onestacked
Copy link
Contributor

@onestacked onestacked commented Sep 14, 2022 •
edited
Loading

Tracking Issue: Tracking Issue for const_slice_split_at_mut

Feature gate: #![feature(const_slice_split_at_mut)]

Still requires const_mut_refs to be actually used, but this feature removes the need to manually re implement these functions in a user crate.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot
Copy link
Collaborator

rustbot commented Sep 14, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 14, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 14, 2022
@onestacked
Copy link
Contributor Author

Makes public stable method slice::split_at_mut unstably const, so

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 14, 2022
@fee1-dead
Copy link
Member

Wrong PR title and description? Also you need to use the rebase feature and we do not accept merge commits. https://rustc-dev-guide.rust-lang.org/git.html#rebasing-and-conflicts

@onestacked onestacked changed the title Constify Fn* trait implementations for references to Fn* traits. Constify slice.split_at_mut(_unstable) Sep 14, 2022
@onestacked
Copy link
Contributor Author

onestacked commented Sep 14, 2022 •
edited
Loading

Yes sorry I did the PR's in the wrong order.

Changed the title and Description to match and rebased on master so it should be correct now.

@onestacked onestacked mentioned this pull request Sep 14, 2022
Closed
6 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@onestacked
Copy link
Contributor Author

r? @fee1-dead

@rust-highfive rust-highfive assigned fee1-dead and unassigned m-ou-se Sep 24, 2022
@fee1-dead
Copy link
Member

@bors r+
cc @rust-lang/wg-const-eval

@bors
Copy link
Contributor

bors commented Sep 25, 2022

📌 Commit 8d6edac has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 25, 2022
@RalfJung RalfJung changed the title Constify slice.split_at_mut(_unstable) Constify slice.split_at_mut(_unchecked) Sep 25, 2022
@fee1-dead
Copy link
Member

@bors rollup

@fee1-dead fee1-dead mentioned this pull request Sep 25, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 25, 2022
@bors
Auto merge of rust-lang#102265 - fee1-dead-contrib:rollup-a7fccbg, r=…
17e8752 
…fee1-dead

Rollup of 8 pull requests

Successful merges:

 - rust-lang#98111 (Clarify `[T]::select_nth_unstable*` return values)
 - rust-lang#101431 (Look at move place's type when suggesting mutable reborrow)
 - rust-lang#101800 (Constify slice.split_at_mut(_unchecked))
 - rust-lang#101997 (Remove support for legacy PM)
 - rust-lang#102194 (Note the type when unable to drop values in compile time)
 - rust-lang#102200 (Constify Default impl's for Arrays and Tuples.)
 - rust-lang#102245 (Constify cmp_min_max_by.)
 - rust-lang#102259 (Type-annotate and simplify documentation of Option::unwrap_or_default)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit da884d2 into rust-lang:master Sep 25, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 25, 2022
@onestacked onestacked deleted the feat/const_split_at_mut branch September 25, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fee1-dead fee1-dead fee1-dead approved these changes

Assignees

@fee1-dead fee1-dead

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
7 participants
@onestacked @rust-highfive @rustbot @fee1-dead @rust-log-analyzer @bors @m-ou-se