-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use head span for rustc_on_unimplemented
's enclosing_scope
attr
#101296
Use head span for rustc_on_unimplemented
's enclosing_scope
attr
#101296
Conversation
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
I am also happy to rename |
@@ -526,7 +526,7 @@ impl<'a, 'tcx> InferCtxtExt<'tcx> for InferCtxt<'a, 'tcx> { | |||
}); | |||
|
|||
let enclosing_scope_span = | |||
tcx.hir().span_with_body(tcx.hir().local_def_id_to_hir_id(body)); | |||
tcx.hir().span(tcx.hir().local_def_id_to_hir_id(body)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tcx.hir().span(tcx.hir().local_def_id_to_hir_id(body)); | |
tcx.def_span(body); |
44b498a
to
21f050e
Compare
r=me with def span used and the proposed variable rename applied |
21f050e
to
edba0c9
Compare
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (a2cdcb3): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
This may make #101281 slightly easier to understand