incremental: migrate diagnostics #100754
Merged
incremental: migrate diagnostics #100754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-translation
rust-highfive
added
the
S-waiting-on-review
|
r=me, rebased after that fatal pr lands |
compiler-errors
added
S-waiting-on-author
This comment was marked as resolved.
This comment was marked as resolved.
davidtwco
force-pushed
the
translation-incremental
branch
2 times, most recently
from
20c0940
to
3becaaf
Compare
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
This was referenced Aug 23, 2022
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 24, 2022
…s, r=davidtwco save_analysis: Migrate diagnostic * Migrate the `rustc_save_analysis` crate's diagnostic to translatable diagnostic structs. Depends on rust-lang#100694 and rust-lang#100754 for #[fatal(..)] support, then rust-lang@aa68eb4, rust-lang@f5219a3, rust-lang@7da52f6 can be removed. (I copied commits from rust-lang#100754)
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 24, 2022
…s, r=davidtwco save_analysis: Migrate diagnostic * Migrate the `rustc_save_analysis` crate's diagnostic to translatable diagnostic structs. Depends on rust-lang#100694 and rust-lang#100754 for #[fatal(..)] support, then rust-lang@aa68eb4, rust-lang@f5219a3, rust-lang@7da52f6 can be removed. (I copied commits from rust-lang#100754)
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Aug 27, 2022
… r=compiler-errors incremental: migrate diagnostics - Apply the diagnostic migration lints to more functions on `Session`, namely: `span_warn`, `span_warn_with_code`, `warn` `note_without_error`, `span_note_without_error`, `struct_note_without_error`. - Add impls of `IntoDiagnosticArg` for `std::io::Error`, `std::path::Path` and `std::path::PathBuf`. - Migrate the `rustc_incremental` crate's diagnostics to translatable diagnostic structs. r? ```@compiler-errors``` cc rust-lang#100717
|
@bors r- failed in rollup I think |
bors
added
S-waiting-on-author
This comment was marked as resolved.
This comment was marked as resolved.
Forward the `Display` implementation for `CrateType` to `IntoDiagnosticArg` so that it can be used in diagnostic structs. Signed-off-by: David Wood <[email protected]>
Apply the diagnostic migration lint to more functions on `Session`. Signed-off-by: David Wood <[email protected]>
Migrate the `rustc_incremental` crate's diagnostics to translatable diagnostic structs. Signed-off-by: David Wood <[email protected]>
davidtwco
force-pushed
the
translation-incremental
branch
from
af8ec72
to
2ff4664
Compare
|
Okay, managed to reproduce this and fix it - diagnostic args weren't being hashed as part of |
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 2ff4664 with merge 79595d1652139e0cdb8fb3ff3ea67f2c9a190a0a... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
I think that's spurious - nothing in this PR should cause a failure in building LLVM? @bors retry |
bors
added
S-waiting-on-bors
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
☀️ Test successful - checks-actions |
This was referenced Jan 31, 2023
|
Finished benchmarking commit (a64ef7d): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Session, namely:span_warn,span_warn_with_code,warnnote_without_error,span_note_without_error,struct_note_without_error.IntoDiagnosticArgforstd::io::Error,std::path::Pathandstd::path::PathBuf.rustc_incrementalcrate's diagnostics to translatable diagnostic structs.r? @compiler-errors
cc #100717