Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: settings menu toggles are cut off on mobile #99794

Closed
jsha opened this issue Jul 27, 2022 · 0 comments · Fixed by #99810
Closed

rustdoc: settings menu toggles are cut off on mobile #99794

jsha opened this issue Jul 27, 2022 · 0 comments · Fixed by #99810
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jsha
Copy link
Contributor

jsha commented Jul 27, 2022

Steps to reproduce:

  1. Visit https://doc.rust-lang.org/nightly/std/string/struct.String.html.
  2. Click settings icon.

Expected result: all toggles are the same size.

Actual result: some toggles are narrower or partially cut off.

image

cc @GuillaumeGomez
@jsha jsha added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Jul 27, 2022
@GuillaumeGomez GuillaumeGomez mentioned this issue Jul 27, 2022
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jul 27, 2022
@GuillaumeGomez
Rollup merge of rust-lang#99810 - GuillaumeGomez:fix-settings-slider-…
151ba52 
…small-width, r=notriddle

Fix settings slider on small width screens

Fixes rust-lang#99794.

Screenshot of the fix:

![Screenshot from 2022-07-27 14-17-08](https://user-images.githubusercontent.com/3050060/181250007-55f982d1-89db-45b7-a4f1-0d1729e6a3e3.png)

cc `@jsha`
r? `@notriddle`
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jul 27, 2022
@GuillaumeGomez
Rollup merge of rust-lang#99810 - GuillaumeGomez:fix-settings-slider-…
06a9299 
…small-width, r=notriddle

Fix settings slider on small width screens

Fixes rust-lang#99794.

Screenshot of the fix:

![Screenshot from 2022-07-27 14-17-08](https://user-images.githubusercontent.com/3050060/181250007-55f982d1-89db-45b7-a4f1-0d1729e6a3e3.png)

cc ``@jsha``
r? ``@notriddle``
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jul 28, 2022
@matthiaskrgr
Rollup merge of rust-lang#99810 - GuillaumeGomez:fix-settings-slider-…
fbbbac9 
…small-width, r=notriddle

Fix settings slider on small width screens

Fixes rust-lang#99794.

Screenshot of the fix:

![Screenshot from 2022-07-27 14-17-08](https://user-images.githubusercontent.com/3050060/181250007-55f982d1-89db-45b7-a4f1-0d1729e6a3e3.png)

cc ```@jsha```
r? ```@notriddle```
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Jul 28, 2022
@Dylan-DPC
Rollup merge of rust-lang#99810 - GuillaumeGomez:fix-settings-slider-…
6f7fe3b 
…small-width, r=notriddle

Fix settings slider on small width screens

Fixes rust-lang#99794.

Screenshot of the fix:

![Screenshot from 2022-07-27 14-17-08](https://user-images.githubusercontent.com/3050060/181250007-55f982d1-89db-45b7-a4f1-0d1729e6a3e3.png)

cc ````@jsha````
r? ````@notriddle````
@bors bors closed this as completed in 3c4a66d Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix settings slider on small width screens GuillaumeGomez/rust
1 participant
@jsha