Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quadratic blowup on -Zunpretty=hir-tree injected 2021-10-19 #97115

Closed
pnkfelix opened this issue May 17, 2022 · 1 comment · Fixed by #97223
Closed

quadratic blowup on -Zunpretty=hir-tree injected 2021-10-19 #97115

pnkfelix opened this issue May 17, 2022 · 1 comment · Fixed by #97223
Labels
requires-nightly This issue requires a nightly compiler in some way. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@pnkfelix
Copy link
Member

Spawned from https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/regression.3A.20hir-tree.20became.20an.20order.20of.20magnitude.20larger/near/282616475

git clone https://github.com/diesel-rs/diesel.git
cd diesel/diesel

# This takes 2 minutes and requires 1.7 GB RAM, and the output is 1.7 GB
time cargo +nightly-2021-10-18 rustc --lib -- -Z unpretty=hir-tree > /tmp/18.txt

# This takes 20 minutes and requires 12.0 GB RAM, and the output is 12.0 GB
time cargo +nightly-2021-10-19 rustc --lib -- -Z unpretty=hir-tree > /tmp/19.txt
@pnkfelix
Copy link
Member Author

@cjgillot reports on the zulip thread that this is due to PR #89124

@pnkfelix pnkfelix added requires-nightly This issue requires a nightly compiler in some way. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 17, 2022
@cjgillot cjgillot mentioned this issue May 20, 2022
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue May 21, 2022
@Dylan-DPC
Rollup merge of rust-lang#97223 - cjgillot:linear-hir-tree, r=jackh726
89df2b2 
Remove quadratic behaviour from -Zunpretty=hir-tree.

Closes rust-lang#97115
@bors bors closed this as completed in 54e36ef May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
requires-nightly This issue requires a nightly compiler in some way. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove quadratic behaviour from -Zunpretty=hir-tree. cjgillot/rust
1 participant
@pnkfelix