Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bors should not close pull requests #9465

Closed
SimonSapin opened this issue Sep 24, 2013 · 2 comments
Closed

bors should not close pull requests #9465

SimonSapin opened this issue Sep 24, 2013 · 2 comments

Comments

@SimonSapin
Copy link
Contributor

When a set of builds/tests pass, bors appears to explicitly close the corresponding pull-request. Is there a reason to do this? If it didn’t, GitHub would automatically mark the PR as "Merged" (which is nicer than "Closed") when bors merges into master and the commit ends up in HEAD’s ancestry.
@pnkfelix
Copy link
Member

bors repo: https://github.com/graydon/bors

@SimonSapin
Copy link
Contributor Author

Thanks @pnkfelix. Closing in favor of graydon/bors#14

djkoloski pushed a commit to djkoloski/rust that referenced this issue Sep 21, 2022
@bors
Auto merge of rust-lang#9465 - Alexendoo:peekable-fp, r=flip1995
9c9aa92 
Fix `unused_peekable` closure and `f(&mut peekable)` false positives

changelog: Fix [`unused_peekable`] false positive when peeked in a closure or called as `f(&mut peekable)`

The `return`/`break` changes aren't part of the fix, they allow an earlier return in some cases. `break` is replaced with `return` for style purposes as they do the same thing in this case

Fixes rust-lang#9456
Fixes rust-lang#9462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pnkfelix @SimonSapin