Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for constify-ing CStr::from_bytes_with_nul_unchecked #90343

Closed
2 tasks done
KamilaBorowska opened this issue Oct 27, 2021 · 5 comments · Fixed by #91855
Closed
2 tasks done

Tracking Issue for constify-ing CStr::from_bytes_with_nul_unchecked #90343

KamilaBorowska opened this issue Oct 27, 2021 · 5 comments · Fixed by #91855
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@KamilaBorowska
Copy link
Contributor

KamilaBorowska commented Oct 27, 2021 •
edited
Loading

The feature gate for the issue is #![feature(const_cstr_unchecked)].

This is a tracking issue for constify-ing CStr::from_bytes_with_nul_unchecked.

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved Questions

XXX --- list all the "unresolved questions" found in the RFC to ensure they are
not forgotten

Implementation history
@KamilaBorowska KamilaBorowska added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Oct 27, 2021
@KamilaBorowska KamilaBorowska mentioned this issue Oct 27, 2021
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 27, 2021
@matthiaskrgr
Rollup merge of rust-lang#90344 - xfix:tracking-issue-const_cstr_unch…
623c3e1 
…ecked, r=Mark-Simulacrum

Add tracking issue number to const_cstr_unchecked

Also created a tracking issue, see rust-lang#90343.

I think it makes sense to stabilize this somewhat soon considering abuse of `transmute` to have this feature in constants, see https://crates.io/crates/cstr for an example. Code can be rewritten to use `mem::transmute` to work on stable.
@Amanieu

This comment has been minimized.

Sign in to view
@Amanieu Amanieu added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Nov 18, 2021
@Amanieu
Copy link
Member

Amanieu commented Nov 18, 2021

@rfcbot merge

@rfcbot
Copy link

rfcbot commented Nov 18, 2021 •
edited by yaahc
Loading

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Nov 18, 2021
@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Dec 2, 2021
@rfcbot
Copy link

rfcbot commented Dec 2, 2021

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Dec 12, 2021
@rfcbot
Copy link

rfcbot commented Dec 12, 2021

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@KamilaBorowska KamilaBorowska mentioned this issue Dec 13, 2021
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 13, 2021
@matthiaskrgr
Rollup merge of rust-lang#91855 - xfix:const_cstr_unchecked, r=dtolnay
c3275c1 
Stabilize const_cstr_unchecked

Closes rust-lang#90343

`@rustbot` modify labels: +T-libs-api
@bors bors closed this as completed in ff214b7 Dec 13, 2021
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stabilize const_cstr_unchecked KamilaBorowska/rust
4 participants
@Amanieu @KamilaBorowska @apiraino @rfcbot