Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.50 added asm tests without architecture gates for those that don't support asm #84038

Closed
infinity0 opened this issue Apr 9, 2021 · 1 comment · Fixed by #84099
Closed

1.50 added asm tests without architecture gates for those that don't support asm #84038

infinity0 opened this issue Apr 9, 2021 · 1 comment · Fixed by #84099
Labels
A-inline-assembly Area: Inline assembly (`asm!(…)`) A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@infinity0
Copy link
Contributor

New tests, since 1.49:

  • ui/asm/naked-invalid-attr.rs

Changed tests (added asm):

  • ui/rfc-2091-track-caller/error-with-naked.rs
  • ui/feature-gates/feature-gate-naked_functions.rs

On architectures that don't support asm these tests error with asm! is unsupported on this target
@infinity0 infinity0 added the C-bug Category: This is a bug. label Apr 9, 2021
@eggyal
Copy link
Contributor

eggyal commented Apr 9, 2021

@rustbot label: +A-inline-assembly +A-testsuite +T-compiler

@rustbot rustbot added A-inline-assembly Area: Inline assembly (`asm!(…)`) A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 9, 2021
@tmiasko tmiasko mentioned this issue Apr 11, 2021
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Apr 12, 2021
@Dylan-DPC
Rollup merge of rust-lang#84099 - tmiasko:asm-only-x86_64, r=Amanieu
c2c6896 
Check for asm support in UI tests that require it

Add `needs-asm-support` compiletest directive, and use it in asm tests
that require asm support without relying on any architecture specific
features.

Closes rust-lang#84038.
@bors bors closed this as completed in 2e7eb85 Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-inline-assembly Area: Inline assembly (`asm!(…)`) A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for asm support in UI tests that require it tmiasko/rust
3 participants
@infinity0 @eggyal @rustbot