Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rls no longer builds after rust-lang/rust#82929 #82932

Closed
rust-highfive opened this issue Mar 9, 2021 · 3 comments · Fixed by #83024
Closed

rls no longer builds after rust-lang/rust#82929 #82932

rust-highfive opened this issue Mar 9, 2021 · 3 comments · Fixed by #83024
Assignees
Labels
C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #82929, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @m-ou-se, do you think you would have time to do the follow-up work?
If so, that would be great!

@rust-highfive rust-highfive added A-rls C-bug Category: This is a bug. labels Mar 9, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Mar 9, 2021

The error:

error[E0432]: unresolved import `cargo::core::enable_nightly_features`
  --> src/tools/rls/rls/src/build/cargo.rs:16:5
   |
16 |     enable_nightly_features, PackageId, Shell, Target, TargetKind, Verbosity, Workspace,
   |     ^^^^^^^^^^^^^^^^^^^^^^^ no `enable_nightly_features` in `core`

error[E0425]: cannot find function `enable_nightly_features` in module `cargo::core`
  --> src/tools/rls/rls/src/project_model.rs:48:22
   |
48 |         cargo::core::enable_nightly_features();
   |                      ^^^^^^^^^^^^^^^^^^^^^^^ not found in `cargo::core`

error: aborting due to 2 previous errors

@jyn514
Copy link
Member

jyn514 commented Mar 9, 2021

@Xanewok See rust-lang/cargo#9181, the way to do this now is to set config.nightly_features_allowed = true.

@jyn514
Copy link
Member

jyn514 commented Mar 10, 2021

Oh oops, you already opened rust-lang/rls#1723.

@Xanewok Xanewok mentioned this issue Mar 11, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this issue Mar 11, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this issue Mar 11, 2021
@bors bors closed this as completed in b3e19a2 Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants