-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--lib should produce reasonable output file names #744
Comments
The man page will need to be updated to reflect this fix. |
Only tested commit 06e5dad on Linux. |
I think we should take a different approach here, and resist more doing more filename munging in link_binary. In rustc::driver::rustc::main there's already a big hunk of code dedicated to figuring out the correct name of the output file, and we have a function in std::os called dylib_filename that builds correct library names for the host platform. For now I think the best thing to do is put another check in main that uses dylib_filename when the compiler is building a library and isn't given an output file. Ultimately all that filename manipulation in main should probably be separated from the call to compile_input and extracted to its own function. |
This looks great, lht. Our main function is finally down to an appropriate size. I've merged both commits. Thanks. |
Updated types of PTRACE requests for musl to be consistent. For some reason the type of ptrace request constants in musl change for the register based requests. As they are used in the same way and this doesn't mimic musl this has been changed for consistency and ease of use. First raised in issue rust-lang#744
add MacroRepOp usage for ?
Bumps [miniz_oxide](https://github.com/Frommi/miniz_oxide) from 0.3.2 to 0.3.3. - [Release notes](https://github.com/Frommi/miniz_oxide/releases) - [Commits](https://github.com/Frommi/miniz_oxide/commits) Signed-off-by: dependabot-preview[bot] <[email protected]>
Right now, if you do "rustc --lib foo.rc", it will produce a library named "foo". It should produce a library named "libfoo.so" on linux and the equivalents on other platforms.
The text was updated successfully, but these errors were encountered: