Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit src/rustllvm/RustWrapper.cpp for C APIs that are now in upstream LLVM. #68955

Open
1 of 2 tasks
eddyb opened this issue Feb 8, 2020 · 0 comments
Open
1 of 2 tasks

Audit src/rustllvm/RustWrapper.cpp for C APIs that are now in upstream LLVM. #68955

eddyb opened this issue Feb 8, 2020 · 0 comments
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@eddyb
Copy link
Member

eddyb commented Feb 8, 2020 •
edited by workingjubilee
Loading

Specifically, functions which are implemented in the oldest supported LLVM version.

We can also consider to polyfill some functions that are available in our fork, but not in some older supported version, using the same name and signature, instead of our own.

cc @alexcrichton @nagisa @nikic @hanna-kruppe
@eddyb eddyb added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. labels Feb 8, 2020
@jonas-schievink jonas-schievink added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 8, 2020
@workingjubilee workingjubilee mentioned this issue Oct 18, 2024
Merged
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Oct 19, 2024
@workingjubilee
Rollup merge of rust-lang#131876 - workingjubilee:llvm-c-c-c-comdat, …
1a151fa 
…r=Zalathar

compiler: Use LLVM's Comdat support

Acting on these long-ago issues:
- rust-lang#46437
- rust-lang#68955
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 19, 2024
@matthiaskrgr
Rollup merge of rust-lang#131876 - workingjubilee:llvm-c-c-c-comdat, …
ccfe9dc 
…r=Zalathar

compiler: Use LLVM's Comdat support

Acting on these long-ago issues:
- rust-lang#46437
- rust-lang#68955
Zalathar added a commit to Zalathar/rust that referenced this issue Oct 20, 2024
@Zalathar
Rollup merge of rust-lang#131876 - workingjubilee:llvm-c-c-c-comdat, …
0bfc49b 
…r=Zalathar

compiler: Use LLVM's Comdat support

Acting on these long-ago issues:
- rust-lang#46437
- rust-lang#68955
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 20, 2024
@rust-timer
Unrolled build for rust-lang#131876
d653e1c 
Rollup merge of rust-lang#131876 - workingjubilee:llvm-c-c-c-comdat, r=Zalathar

compiler: Use LLVM's Comdat support

Acting on these long-ago issues:
- rust-lang#46437
- rust-lang#68955
lnicola pushed a commit to lnicola/rust-analyzer that referenced this issue Oct 22, 2024
@Zalathar
Rollup merge of #131876 - workingjubilee:llvm-c-c-c-comdat, r=Zalathar
3925175 
compiler: Use LLVM's Comdat support

Acting on these long-ago issues:
- rust-lang/rust#46437
- rust-lang/rust#68955
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eddyb @jonas-schievink