Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve LLVM IR Code generation #6819

Closed
Aatch opened this issue May 30, 2013 · 4 comments
Closed

Improve LLVM IR Code generation #6819

Aatch opened this issue May 30, 2013 · 4 comments
Labels
A-codegen Area: Code generation metabug Issues about issues themselves ("bugs about bugs")

Comments

@Aatch
Copy link
Contributor

Aatch commented May 30, 2013

This is a metabug to group together a bunch of related issues do with our current generation of LLVM IR.

The IR we produce is very verbose, this causes an inordinate amount of time to be spent during the optimization passes that we could trivially prevent by simply not outputting these sequences.

Instrumentation and testing issues

Too many copies of functions issues

(see http://people.mozilla.org/~graydon/symbols-by-name.txt)

Too much codegen issues

Incorrect or LLVM-frustrating codegen issues

Overall use of LLVM issues

@graydon
Copy link
Contributor

graydon commented May 30, 2013

See -Z count-llvm-insns and pipe output to xdu.

@Aatch
Copy link
Contributor Author

Aatch commented May 30, 2013

@graydon or, for people that do not have xdu, if you have xdiskusage instead, you can do rustc foo.rs -Z count-llvm-insns | xdiskusage

@farnoy
Copy link
Contributor

farnoy commented Aug 20, 2013

Sorry for going off topic a bit, but this could improve readability of these kinds of metabugs: https://github.com/blog/1375-task-lists-in-gfm-issues-pulls-comments

@thestinger
Copy link
Contributor

I think this kind of categorization is covered well by the usage of tags (I-slow, I-compiletime). It's not ever going to be possible to complete this metabug or mark it as a milestone so I don't see much value in leaving it open forever. The discussion here is out of date too.

flip1995 pushed a commit to flip1995/rust that referenced this issue Mar 11, 2021
Fix `manual_map` false positives

fixes: rust-lang#6795
fixes: rust-lang#6797
fixes: rust-lang#6811
fixes: rust-lang#6819

changelog: Fix false positives for `manual_map` when `return`, `break`, `continue`, `yield`, `await`, and partially moved values are used.
changelog: Don't expand macros in suggestions  for `manual_map`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-codegen Area: Code generation metabug Issues about issues themselves ("bugs about bugs")
Projects
None yet
Development

No branches or pull requests

4 participants