Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miri no longer builds after rust-lang/rust#63420 #64441

Closed
rust-highfive opened this issue Sep 13, 2019 · 3 comments · Fixed by rust-lang/miri#951
Closed

miri no longer builds after rust-lang/rust#63420 #64441

rust-highfive opened this issue Sep 13, 2019 · 3 comments · Fixed by rust-lang/miri#951
Assignees
@eddyb @RalfJung @oli-obk
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #63420, I observed that the tool miri no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @spastorino, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @oli-obk, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 13, 2019
@RalfJung
Copy link
Member

Duplicate of #64363.

@spastorino
Copy link
Member

It's unrelated to #64363, providing a PR ...

@spastorino spastorino mentioned this issue Sep 14, 2019
Merged
@RalfJung
Copy link
Member

Well, both issues track "Miri doesn't work". There are currently multiple things that break Miri, but these issues here do not track any particular reason why Miri is broken, they just track the bad toolstate.

bors added a commit to rust-lang/miri that referenced this issue Sep 15, 2019
@bors
Auto merge of #951 - spastorino:place-2-0, r=RalfJung
508fdb8 
Place projection field is now Box<[PlaceElem<'tcx>]>

Closes rust-lang/rust#64441
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddyb eddyb

@RalfJung RalfJung

@oli-obk oli-obk

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Place projection field is now Box<[PlaceElem<'tcx>]> spastorino/miri
5 participants
@spastorino @eddyb @RalfJung @oli-obk @rust-highfive