Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure: Clang version check should use "based on" version for Apple Clang #6419

Closed
lilyball opened this issue May 11, 2013 · 2 comments
Closed

configure: Clang version check should use "based on" version for Apple Clang #6419

lilyball opened this issue May 11, 2013 · 2 comments

Comments

@lilyball
Copy link
Contributor

Apple Clang version numbering doesn't match the open source project. Typically it's a full major version ahead. This is why the configure script currently allows for 4.1* and 4.2*. However, this isn't particularly future-proof. The configure script should instead learn to use the "based on" version when present, because this describes what the open source version is. For example, the version string looks something like "Apple LLVM version 4.2 (clang-421.2.1) (based on LLVM 3.2svn)".
@lilyball
Copy link
Contributor Author

Here's a new version of the sed command that should produce the "based on" version when the version string contains it: sed 's/.*\(version .*\)/\1/; s/.*based on \(LLVM .*\))/\1/'

lilyball added a commit to lilyball/rust that referenced this issue May 25, 2013
@lilyball
Issue rust-lang#6419: Better clang version detection for Apple Clang
bf57d65 
Apple Clang uses different version numbering than "regular" clang, but
it also provides the "regular" version it's based on. Update the sed
pattern to pull out this "regular" version number instead of the Apple
version number.
@lilyball
Copy link
Contributor Author

This was just handled via the pull request #6739

flip1995 pushed a commit to flip1995/rust that referenced this issue Dec 6, 2020
@bors
Auto merge of rust-lang#6419 - giraffate:fix_a_style_of_texts_in_size…
4340229 
…_of_in_element_count, r=flip1995

Fix a style of texts in `size_of_in_element_count`

Add missing ` to texts

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lilyball