Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow package IDs to refer to the middle of a source repository #6408

Closed
catamorphism opened this issue May 10, 2013 · 3 comments
Closed

Allow package IDs to refer to the middle of a source repository #6408

catamorphism opened this issue May 10, 2013 · 3 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@catamorphism
Copy link
Contributor

Sub-bug of #5677

Currently, rustpkg assumes that a remote package ID refers to the root level of a particular source repository. @brson suggested that to obviate the need for servo to use git submodules, we could allow package IDs to point into a subdirectory of a repo. It's unclear whether we should implement this. See discussion at https://etherpad.mozilla.org/Rustpkg-Servo-meeting

@ghost ghost assigned catamorphism May 10, 2013
@emberian
Copy link
Member

This seems like a good idea to me. Imagine a C library that ships rust bindings in a 'rust' subdirectory.

@lilyball
Copy link
Contributor

Go allows you to reference a sub-path of a repo. It checks out the correct repo, and only builds that sub-path.

@lilyball
Copy link
Contributor

If this is implemented (and I think it should be), then rustpkg should also stop recursively searching for lib.rs (and the other magic files) and instead require them to be in the root. This is because rustpkg assumes that the last path component of the pkgid is the name of the library, and it would be very confusing if I could type both rustpkg install github.com/foo/bar and rustpkg install github.com/foo/bar/baz and have both build the same library, but only the latter successfully install.

bors added a commit that referenced this issue Sep 12, 2013
…son,catamorphism

r? @brson Package IDs can now refer to a subdirectory of a particular source
tree, and not just a top-level directory with a src/ directory as its
parent.

For example, referring to the package ID a/b/c/d , in workspace W,
if W/src/a is a package, will build the sources for the package in
a/b/c/d (and not other crates in W/src/a).

Closes #6408
@catamorphism catamorphism removed their assignment Jun 16, 2014
flip1995 pushed a commit to flip1995/rust that referenced this issue Jan 30, 2021
Fix false positive in write_literal and print_literal (numeric literals)

changelog: No longer lint numeric literals in [`write_literal`] and [`print_literal`].

Fixes rust-lang#6335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants