-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow package IDs to refer to the middle of a source repository #6408
Comments
This seems like a good idea to me. Imagine a C library that ships rust bindings in a 'rust' subdirectory. |
Go allows you to reference a sub-path of a repo. It checks out the correct repo, and only builds that sub-path. |
If this is implemented (and I think it should be), then rustpkg should also stop recursively searching for |
…son,catamorphism r? @brson Package IDs can now refer to a subdirectory of a particular source tree, and not just a top-level directory with a src/ directory as its parent. For example, referring to the package ID a/b/c/d , in workspace W, if W/src/a is a package, will build the sources for the package in a/b/c/d (and not other crates in W/src/a). Closes #6408
Fix false positive in write_literal and print_literal (numeric literals) changelog: No longer lint numeric literals in [`write_literal`] and [`print_literal`]. Fixes rust-lang#6335
Sub-bug of #5677
Currently, rustpkg assumes that a remote package ID refers to the root level of a particular source repository. @brson suggested that to obviate the need for servo to use git submodules, we could allow package IDs to point into a subdirectory of a repo. It's unclear whether we should implement this. See discussion at https://etherpad.mozilla.org/Rustpkg-Servo-meeting
The text was updated successfully, but these errors were encountered: