Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NonZero signed variants not available in std #59834

Closed
Mark-Simulacrum opened this issue Apr 9, 2019 · 0 comments · Fixed by #59835
Closed

NonZero signed variants not available in std #59834

Mark-Simulacrum opened this issue Apr 9, 2019 · 0 comments · Fixed by #59835
Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

The NonZero signed variants are not re-exported in std here: https://github.com/rust-lang/rust/blob/master/src/libstd/num.rs#L15

We should duplicate that line and re-export them.

cc @rust-lang/release @rust-lang/libs -- this will likely slip into 1.34, but we will backport the fix into 1.35
@Mark-Simulacrum Mark-Simulacrum added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Apr 9, 2019
@tesuji tesuji mentioned this issue Apr 10, 2019
Merged
@pietroalbini pietroalbini mentioned this issue Apr 10, 2019
Merged
bors added a commit that referenced this issue Apr 10, 2019
@bors
Auto merge of #59843 - pietroalbini:stable-extras, r=Mark-Simulacrum
91856ed 
[stable] Cherry-pick stdlib fix

Cherry-picked:

* #59835: Re-export NonZero signed variant in std

r? @Mark-Simulacrum
cc #59834 @rust-lang/release
sanxiyn added a commit to sanxiyn/rust that referenced this issue Apr 11, 2019
@sanxiyn
Rollup merge of rust-lang#59835 - lzutao:nonzero-signed, r=Mark-Simul…
da1748b 
…acrum

Re-export NonZero signed variant in std

cc  rust-lang#59834
Centril added a commit to Centril/rust that referenced this issue Apr 12, 2019
@Centril
Rollup merge of rust-lang#59835 - lzutao:nonzero-signed, r=Mark-Simul…
2a24c8f 
…acrum

Re-export NonZero signed variant in std

Closes  rust-lang#59834 .
Centril added a commit to Centril/rust that referenced this issue Apr 13, 2019
@Centril
Rollup merge of rust-lang#59835 - lzutao:nonzero-signed, r=Mark-Simul…
1d1693c 
…acrum

Re-export NonZero signed variant in std

Closes  rust-lang#59834 .
Centril added a commit to Centril/rust that referenced this issue Apr 13, 2019
@Centril
Rollup merge of rust-lang#59835 - lzutao:nonzero-signed, r=Mark-Simul…
92be8d0 
…acrum

Re-export NonZero signed variant in std

Closes  rust-lang#59834 .
Centril added a commit to Centril/rust that referenced this issue Apr 13, 2019
@Centril
Rollup merge of rust-lang#59835 - lzutao:nonzero-signed, r=Mark-Simul…
449697b 
…acrum

Re-export NonZero signed variant in std

Closes  rust-lang#59834 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-export NonZero signed variant in std tesuji/rustc
1 participant
@Mark-Simulacrum