-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blank right side border in table generated by rustdoc in Firefox #58134
Comments
Do the tables render without the right side border on Some screenshots from my laptop / desktop: Firefox Firefox Firefox Nightly Although I wasn't able to recreate the blank side, only Firefox Nightly rendered the table to expectations (there are slight offsets in previous versions). |
Unable to test it locally currently, but one difference is that the tables on collections’ page has borders in the markdown as well. Does it make any difference by adding them? It doesn’t make a difference on github markdown, but worth a shot. //! ## Sequences
//!
//! | | get(i) | insert(i) | remove(i) | append | split_off(i) |
//! |----------------|----------------|-----------------|----------------|--------|----------------|
//! | [`Vec`] | O(1) | O(n-i)* | O(n-i) | O(m)* | O(n-i) |
//! | [`VecDeque`] | O(1) | O(min(i, n-i))* | O(min(i, n-i)) | O(m)* | O(min(i, n-i)) |
//! | [`LinkedList`] | O(min(i, n-i)) | O(min(i, n-i)) | O(min(i, n-i)) | O(1) | O(min(i, n-i)) |
|
@memoryruins I added left and right borders, and even when using module document |
@lzutao Please make your code available somewhere so I can test it because I can't reproduce it... |
@GuillaumeGomez I updated the issue details. |
Missing a cell? Doc source/// Each Vietnamese monosyllabic word can be decomposed at most into 4 parts,
/// which are:
///
/// 1. The initial group of consonants
/// 1. The vowel group
/// 1. The group of final consonants
/// 1. The tonal accent
///
/// # Examples
///
/// Word | Consonant | Vowel | Consonant | Accent
/// --------------- | --------- | ----- | --------- | ------
/// trường (school) | tr | ươ | ng | Grave
/// muối (salt) | m | uôi | | Acute
/// ao (the pond) | | ao | |
|
Interesting! I was about to look into it. I'll do the two at once. |
…=QuietMisdreavus Fix tables display Fixes rust-lang#58134. cc @lzutao r? @QuietMisdreavus
Edit: Add test code in metadata.
It is ugly in my crate (not public yet), see below image displayed in Firefox:
but in Chromium:
At least in Chromium, the right side border of the table is displayed.
I tested in both 1.31.0, 1.32.0 and 1.34.0-nightly (852701a 2019-02-01), those have the same effect. I didn't test previous versions because I'm using Rust 2018.
Metadata
OS and software info
OS: Xubuntu 18.04.1
Browser: Firefox 65.0 (All extensions are disabled)
Rustdoc:
Build with below code to test locally with `rustdoc`
The text was updated successfully, but these errors were encountered: