Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::collections::binary_heap::PeekMut produces extra bound checks #58121

Closed
lnicola opened this issue Feb 3, 2019 · 0 comments
Closed

std::collections::binary_heap::PeekMut produces extra bound checks #58121

lnicola opened this issue Feb 3, 2019 · 0 comments
Labels
A-collections Area: `std::collection` C-enhancement Category: An issue proposing an enhancement or a PR with one. I-slow Issue: Problems and improvements with respect to performance of generated code.

Comments

@lnicola
Copy link
Member

lnicola commented Feb 3, 2019

Seen on https://www.reddit.com/r/rust/comments/ahajve/peekmut_and_bounds_checks/.
@lnicola lnicola mentioned this issue Feb 3, 2019
Merged
@jonas-schievink jonas-schievink added I-slow Issue: Problems and improvements with respect to performance of generated code. C-enhancement Category: An issue proposing an enhancement or a PR with one. A-collections Area: `std::collection` labels Feb 3, 2019
kennytm added a commit to kennytm/rust that referenced this issue Feb 7, 2019
@kennytm
Rollup merge of rust-lang#58123 - lnicola:binary-heap-no-bounds-check…
8bc05ba 
…s, r=sfackler

Avoid some bounds checks in binary_heap::{PeekMut,Hole}

Fixes rust-lang#58121.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-collections Area: `std::collection` C-enhancement Category: An issue proposing an enhancement or a PR with one. I-slow Issue: Problems and improvements with respect to performance of generated code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lnicola @jonas-schievink