-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rustpkg should support versions integrated with a VCS #5684
Milestone
Comments
I'm about to submit a pull request for just parsing the version at all. I'll implement the ability to request a specific version next. |
catamorphism
added a commit
to catamorphism/rust
that referenced
this issue
May 30, 2013
For now, the test I added just checks that PkgId::new parses the version number out of a git repo's tags list, where relevant.
catamorphism
added a commit
to catamorphism/rust
that referenced
this issue
Jun 9, 2013
For now, the test I added just checks that PkgId::new parses the version number out of a git repo's tags list, where relevant.
Fixed in d92b435 |
This was referenced Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sub-bug of #5677
Rustpkg should support pkgids with version numbers in them, rather than treating versions as a separate component of a dependency specification. The easiest thing I can think of is to use a URI-like fragment-specifier:
path/to/pkgid#version
. Thenversion
is passed through somewhat directly to the underlying fetch mechanism (as a revision identifier -- either a tag/ref or a hash) and is mapped into a (sub)directory when checking out and building packages. We can start with specific revisions and extend to accepting revision-ranges (say, separated by..
) in dependency requirements at some point if we find this is something people want.Note that this is not in opposition to using semvers. We should encourage revision tags that are semvers. But users will occasionally want or need to refer to non-semver tags:
HEAD
of some repo, while doing developmentWe can (probably?) differentiate cases using the following algorithm (though it's getting tight):
..
pair. If there's such a pair, it's a version range. If not, it's a single version..
in a version, try to parse it as a semver.The text was updated successfully, but these errors were encountered: