Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustfmt and rls are only available on x86, x86_64, aarch64, and arm+neon #56261

Closed
cuviper opened this issue Nov 26, 2018 · 7 comments
Closed

rustfmt and rls are only available on x86, x86_64, aarch64, and arm+neon #56261

cuviper opened this issue Nov 26, 2018 · 7 comments
Labels
regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue.

Comments

@cuviper
Copy link
Member

cuviper commented Nov 26, 2018

Use of rustfmt -> bytecount -> simd only works on x86, x86_64, aarch64, and arm+neon, so all other arches are broken. See also rust-lang/rustfmt#3216.

I'm marking this as a regression since rustfmt and rls worked fine on all arches on 1.30 stable. I'm aware the rest are not Tier-1 targets though.

I believe a simple workaround for distro packagers like myself would be to just patch out the enablement of bytecount's simd-accel feature in rustfmt/Cargo.toml.
@cuviper cuviper added regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. labels Nov 26, 2018
@alexcrichton
Copy link
Member

@nrc this seems pretty bad, maybe the dependency can be removed for now?

@alexcrichton
Copy link
Member

Er nvmd, looks like it's fixed upstream, I think bother the beta and master branches now need an update?

alexcrichton added a commit to alexcrichton/rust that referenced this issue Nov 29, 2018
@alexcrichton
Update rustfmt to build on all arches
9023e94 
cc rust-lang#56261
@alexcrichton
Copy link
Member

@nrc I've created a rust-1.31.0 branch of rustfmt which includes one commit branched off the 1.0.0 tag (what we previously had on the beta branch). That commit comes from rust-lang/rustfmt#3220 which closed rust-lang/rustfmt#3216.

I've pushed that commit to #56352 to get this in ASAP. I haven't updated the master branch of this repo, so that'll need to be done before this issue is fully closed.

@alexcrichton
Copy link
Member

Retagging as a nightly regression now that the rollup has landed, @cuviper can you confirm tomorrow that beta has all the available rustfmts? It looks like rustfmt-beta-arm-unknown-linux-gnueabi.tar.xz got uploaded at least!

@alexcrichton alexcrichton added regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. and removed regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Nov 30, 2018
@cuviper
Copy link
Member Author

cuviper commented Dec 1, 2018

Well, I checked, but it seems beta is still at rustc 1.31.0-beta.19 (42053f9f0 2018-11-26).

nrc added a commit to nrc/rust that referenced this issue Dec 1, 2018
@nrc
Update RLS and Rustfmt
7a7445b 
Closes rust-lang#56261
@nrc nrc mentioned this issue Dec 1, 2018
Merged
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Dec 1, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#56406 - nrc:update, r=kennytm
4f3b334 
Update RLS and Rustfmt

Closes rust-lang#56261

r? @kennytm
@cuviper
Copy link
Member Author

cuviper commented Dec 1, 2018

OK, 1.31.0-beta.20 (8940af3ce 2018-11-30) looks good, thanks!

@alexcrichton
Copy link
Member

Perfect, thanks!

bors added a commit that referenced this issue Dec 2, 2018
@bors
Auto merge of #56406 - nrc:update, r=kennytm
0765eb9 
Update RLS and Rustfmt

Closes #56261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cuviper @alexcrichton