Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error[E0541]: unknown meta item should show known unused meta items #51469

Closed
Havvy opened this issue Jun 10, 2018 · 0 comments
Closed

error[E0541]: unknown meta item should show known unused meta items #51469

Havvy opened this issue Jun 10, 2018 · 0 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints

Comments

@Havvy
Copy link
Contributor

Havvy commented Jun 10, 2018

In #[deprecated(since="1.0.1", reason="Bad performance."], the error message should state that reason is unknown and that the known one is note since the only known meta items for deprecated are "since" and "note".

But this for every attribute that takes meta items.
@stokhos stokhos added the A-diagnostics Area: Messages for errors, warnings, and lints label Jun 10, 2018
@euclio euclio mentioned this issue Jul 1, 2018
Merged
pietroalbini added a commit to pietroalbini/rust that referenced this issue Jul 3, 2018
@pietroalbini
Rollup merge of rust-lang#51958 - euclio:attr-refactor, r=petrochenkov
855436f 
Show known meta items in unknown meta items error

This PR adds a label to E0541. It also factors built-in attribute parsing into a submodule of `attr` for ease of future refactoring.

Fixes rust-lang#51469.
pietroalbini added a commit to pietroalbini/rust that referenced this issue Jul 3, 2018
@pietroalbini
Rollup merge of rust-lang#51958 - euclio:attr-refactor, r=petrochenkov
bd0fe73 
Show known meta items in unknown meta items error

This PR adds a label to E0541. It also factors built-in attribute parsing into a submodule of `attr` for ease of future refactoring.

Fixes rust-lang#51469.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Havvy @stokhos