-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mul_add
documentation is inaccurate
#49842
Comments
cc @pitdicker |
cc #44805, dedicated FMA instructions are not universally available and we can't very well replace |
kennytm
added
A-docs
Area: Documentation for any part of the project, including the compiler, standard library, and tools
C-bug
Category: This is a bug.
labels
Apr 10, 2018
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this issue
May 9, 2018
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this issue
May 10, 2018
Clarify in the docs that `mul_add` is not always faster. Fixes rust-lang#49842. Other resources: - https://users.rust-lang.org/t/why-does-the-mul-add-method-produce-a-more-accurate-result-with-better-performance/1626 - https://en.wikipedia.org/wiki/Multiply%E2%80%93accumulate_operation
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this issue
May 10, 2018
Clarify in the docs that `mul_add` is not always faster. Fixes rust-lang#49842. Other resources: - https://users.rust-lang.org/t/why-does-the-mul-add-method-produce-a-more-accurate-result-with-better-performance/1626 - https://en.wikipedia.org/wiki/Multiply%E2%80%93accumulate_operation
frewsxcv
added a commit
to frewsxcv/num-traits
that referenced
this issue
May 20, 2018
frewsxcv
added a commit
to frewsxcv/num-traits
that referenced
this issue
May 20, 2018
bors bot
added a commit
to rust-num/num-traits
that referenced
this issue
May 21, 2018
70: Clarify in the docs that `mul_add` is not always faster. r=cuviper a=frewsxcv More info: - rust-lang/rust#49842 - rust-lang/rust#50572 Co-authored-by: Corey Farwell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to the documentation of
mul_add
:This seems not to be true in general. On my machine,
a.mul_add(b, c)
is slower thana * b + c
when compiling withouttarget-cpu=native
.The text was updated successfully, but these errors were encountered: