Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"help: consider adding a leading b" needs a macro check #48835

Closed
durka opened this issue Mar 8, 2018 · 1 comment · Fixed by #52160
Closed

"help: consider adding a leading b" needs a macro check #48835

durka opened this issue Mar 8, 2018 · 1 comment · Fixed by #52160
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-diagnostics Working group: Diagnostics

Comments

@durka
Copy link
Contributor

durka commented Mar 8, 2018

If you try to, e.g., include_str!(...) into a place expecting &[u8], the error message suggests binclude_str!(...).
@Centril Centril added A-diagnostics Area: Messages for errors, warnings, and lints A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) WG-diagnostics Working group: Diagnostics labels Mar 8, 2018
@oli-obk
Copy link
Contributor

oli-obk commented Mar 8, 2018

very much related: #48364 (suggesting nclude_bytes! if str was expected and include_bytes! was used)

@zackmdavis zackmdavis mentioned this issue Mar 9, 2018
Closed
@XAMPPRocky XAMPPRocky added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 14, 2018
@euclio euclio mentioned this issue Jul 8, 2018
Merged
euclio added a commit to euclio/rust that referenced this issue Jul 8, 2018
@euclio
add regression test for rust-lang#48835
1be1d90 
Fixes rust-lang#48835.

The underlying issue was fixed in rust-lang#51978.
bors added a commit that referenced this issue Jul 9, 2018
@bors
Auto merge of #52160 - euclio:include-macros, r=oli-obk
c30acc7 
add regression test for #48835

Fixes #48835.

The underlying issue was fixed in #51978.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-diagnostics Working group: Diagnostics
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add regression test for #48835 euclio/rust
4 participants
@durka @oli-obk @Centril @XAMPPRocky