Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Make sure that we can bootstrap with cfg(parallel_queries). #48607

Closed
Tracked by #48685
michaelwoerister opened this issue Feb 28, 2018 · 12 comments
Closed
Tracked by #48685

CI: Make sure that we can bootstrap with cfg(parallel_queries). #48607

michaelwoerister opened this issue Feb 28, 2018 · 12 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@michaelwoerister
Copy link
Member

For now a docker image that just builds with cfg(parallel_queries) (but without running tests) should be enough.

cc @Zoxc

@Zoxc Zoxc added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Mar 9, 2018
@Zoxc
Copy link
Contributor

Zoxc commented Mar 9, 2018

I would also like Travis PRs builds to run x.py check with cfg(parallel_queries) before doing the normal build without cfg(parallel_queries).

@Zoxc
Copy link
Contributor

Zoxc commented Mar 9, 2018

cc @rust-lang/infra

@kennytm kennytm added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Mar 9, 2018
@shepmaster shepmaster changed the title CI: Make sure the we can bootstrap with cfg(parallel_queries). CI: Make sure that we can bootstrap with cfg(parallel_queries). Mar 9, 2018
@alexcrichton
Copy link
Member

We unfortunately don't have a lot of spare cycles on CI right now, both in terms of overall capacity and extra time to run more tests on builders (we're already timing out all over the place). If this is "things are on fire we really need this" then this can be prioritized, but otherwise this probably won't happen for awhile.

@alexcrichton
Copy link
Member

er, didn't mean to close

@michaelwoerister
Copy link
Member Author

I think it would be great if we could at least make sure that stage 0 builds with cfg(parallel_queries). Down the line we'll have to run test too but that's not so urgent.

@alexcrichton
Copy link
Member

That may be easier to do so, yeah. We could probably do something like RUSTFLAGS_STAGE0=... on whatever builder executes the fastest today, such as x86_64-gnu-debug

@Zoxc
Copy link
Contributor

Zoxc commented Mar 12, 2018

I'd be satisfied with running x.py check on some configuration which should take like 6 minutes (assuming it skips LLVM).

@Zoxc
Copy link
Contributor

Zoxc commented Mar 16, 2018

Running x.py check first would also serve to quickly reject PRs with compile errors. I'm not sure that matters for the bors queue, but it might help with PR builds.

@alexcrichton
Copy link
Member

Oh yeah that could for sure work! The check build finishes so quickly we could just add a slew of extra builders on Travis. They can get scheduled in the cracks between other builds

@michaelwoerister
Copy link
Member Author

That seems like a good first step.

@michaelwoerister
Copy link
Member Author

The ./x.py check approach was added in #49120 and #50444 extends it a little.

kennytm added a commit to kennytm/rust that referenced this issue May 4, 2018
…ries-in-ci, r=alexcrichton

Add a CI job that makes sure rustc builds with parallel queries enabled.

This shouldn't take up too much CI time `:)`

cc rust-lang#48607
cc @Zoxc

r? @alexcrichton
bors added a commit that referenced this issue May 5, 2018
… r=alexcrichton

Add a CI job that makes sure rustc builds with parallel queries enabled.

This shouldn't take up too much CI time `:)`

cc #48607
cc @Zoxc

r? @alexcrichton
@XAMPPRocky XAMPPRocky added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label May 14, 2018
@jonas-schievink jonas-schievink added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) and removed T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-build labels Apr 21, 2019
@Mark-Simulacrum
Copy link
Member

Closing as per the above. @aturon is taking over some of the parallel compiler review work though so I think as we move closer to making that stable we'll probably want to enable more builders and such but keeping this open doesn't seem too useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

7 participants