Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate splitting 32bit windows tests #47911

Closed
aidanhs opened this issue Jan 31, 2018 · 4 comments
Closed

Investigate splitting 32bit windows tests #47911

aidanhs opened this issue Jan 31, 2018 · 4 comments
Assignees
@Mark-Simulacrum
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@aidanhs
Copy link
Member

aidanhs commented Jan 31, 2018

https://mozilla.logbot.info/rust-infra/20180130#c14213927-c14214012

It'd be good to get some notes on how this might be done in rustbuild.

A working implementation would be fine too :)
@aidanhs
Copy link
Member Author

aidanhs commented Jan 31, 2018

cc #46903

@arazabishov arazabishov added A-testsuite Area: The testsuite used to check the correctness of rustc A-build C-enhancement Category: An issue proposing an enhancement or a PR with one. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jan 31, 2018
@Mark-Simulacrum Mark-Simulacrum added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) and removed A-build labels Feb 2, 2018
@Mark-Simulacrum
Copy link
Member

I'll do my best to come up with some instructions this weekend. If someone is super interested and I haven't yet, ping me, because it'll help expedite matters.

@Mark-Simulacrum Mark-Simulacrum mentioned this issue Feb 9, 2018
Merged
@aidanhs
Copy link
Member Author

aidanhs commented Feb 13, 2018

Test splitting also useful for #48192 which is causing timeouts, though the root cause is different.

bors added a commit that referenced this issue Feb 14, 2018
@bors
Auto merge of #48105 - Mark-Simulacrum:exclude-paths, r=alexcrichton
fb623fa 
Implement excluding a build-step via --exclude

First step to fixing #47911. This doesn't change any CI configuration, but implements what I believe necessary to make that feasible in rustbuild.

In theory this should be sufficient to allow someone to open a PR against .travis.yml and appveyor.yml which splits the Windows 32-bit tests and maybe the OS X tests into multiple builders (depending on what our cost-concerns are) to reduce runtimes.

r? @alexcrichton
cc @kennytm
bors added a commit that referenced this issue Feb 15, 2018
@bors
Auto merge of #48105 - Mark-Simulacrum:exclude-paths, r=alexcrichton
c83fa5d 
Implement excluding a build-step via --exclude

First step to fixing #47911. This doesn't change any CI configuration, but implements what I believe necessary to make that feasible in rustbuild.

In theory this should be sufficient to allow someone to open a PR against .travis.yml and appveyor.yml which splits the Windows 32-bit tests and maybe the OS X tests into multiple builders (depending on what our cost-concerns are) to reduce runtimes.

r? @alexcrichton
cc @kennytm
@alexcrichton
Copy link
Member

This has been implemented on master and we'll continue doing so while we hit timeouts, so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexcrichton @aidanhs @arazabishov @Mark-Simulacrum