Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

musl ARMv7 uses NEON #47765

Closed
jminer opened this issue Jan 26, 2018 · 1 comment
Closed

musl ARMv7 uses NEON #47765

jminer opened this issue Jan 26, 2018 · 1 comment
Labels
A-codegen Area: Code generation O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state

Comments

@jminer
Copy link

jminer commented Jan 26, 2018 •
edited
Loading

In #35814, the armv7-unknown-linux-gnueabihf target was changed to not use NEON, but the armv7-unknown-linux-musleabihf target was not changed. I just used the musl target to compile a binary for my router (OpenWRT uses musl), but it dies with "Illegal instruction" in Mutex::new on vld1.32 (a NEON instruction).

$ rustc --print cfg --target armv7-unknown-linux-musleabihf | grep neon
target_feature="neon"

Should armv7-unknown-linux-musleabihf have NEON disabled as well? I think it is confusing to have one armv7 target with NEON enabled and the other with it disabled.
@alexcrichton
Copy link
Member

Ah yeah seems like an oversight on our part! I think it'd be fine to remove neon for consistency with the gnu target

@nagisa nagisa added A-codegen Area: Code generation O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state labels Jan 26, 2018
@sanxiyn sanxiyn mentioned this issue Feb 23, 2018
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue Mar 3, 2018
@Manishearth
Rollup merge of rust-lang#48466 - sanxiyn:no-neon, r=alexcrichton
414dddf 
Disable NEON on musl ARMv7

`armv7-unknown-linux-musleabihf` target diverged a bit from `armv7-unknown-linux-gnueabihf` target. This PR re-syncs them.

Fix rust-lang#47765.
kennytm added a commit to kennytm/rust that referenced this issue Mar 3, 2018
@kennytm
Rollup merge of rust-lang#48466 - sanxiyn:no-neon, r=alexcrichton
ae6fe8f 
Disable NEON on musl ARMv7

`armv7-unknown-linux-musleabihf` target diverged a bit from `armv7-unknown-linux-gnueabihf` target. This PR re-syncs them.

Fix rust-lang#47765.
This was referenced Jan 25, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @nagisa @jminer