Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Vim extensions into separate repository #3756

Closed
ahmadsalim opened this issue Oct 13, 2012 · 15 comments
Closed

Split Vim extensions into separate repository #3756

ahmadsalim opened this issue Oct 13, 2012 · 15 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@ahmadsalim
Copy link

Currently the Vim extensions are in a subdirectory in the main repository, specifically here: src/etc/vim.
This makes it less user-friendly with Vim extension handling tools like VAM, Vundle and Pathogen that rely on separate git repositories for handling each separate extension.

While it is possible in Vundle to configure a "run-time path" such that a subrepository is chosen, this might be less optimal.
This is because the whole rust repository (which is fairly large) must be checked each time when installing/updating vim extensions, instead of only the smaller vim-related parts.

On my computer this takes at least one minute, which is a reasonably long time considering the parts needed.

@berkerpeksag
Copy link

I've created a separate repository for the Vim extensions(with full history): https://github.com/berkerpeksag/vim-rust/commits/master

You can fork/transfer this repository into Mozilla organization or just import vim.patch into a new one:

$ git init
$ git am < vim.patch
$ git push -u <your_remote_name> master

I can open a new pull request to remove the src/etc/vim directory if this solution is okay.

@upsuper
Copy link
Contributor

upsuper commented Dec 17, 2012

Please split vim extension into a seperate repo. It is not difficult, but helpful.

@berkerpeksag
Copy link

@upsuper you can use the vim-rust repo until this issue fixed: https://github.com/berkerpeksag/vim-rust

@nikomatsakis
Copy link
Contributor

Not critical for 0.6; removing milestone

@catamorphism
Copy link
Contributor

Nominating for milestone 5, production-ready

@brson
Copy link
Contributor

brson commented Jun 27, 2013

Is this true for emacs too?

@pnkfelix
Copy link
Member

not accepting for milestone. (may or may not actually take action on this bug eventually, but did not close outright during triage.)

@huonw
Copy link
Member

huonw commented Sep 3, 2013

Triage: no change, the canonical source is still src/etc/vim (and similarly for the emacs, gedit and kate modes and the zsh completion file).

@mmalecki
Copy link

Ping? This would be great to separate out to a different repository as it would make installing rust vim plugin with pathogen a breeze.

@huonw
Copy link
Member

huonw commented Dec 14, 2013

@mmalecki you can use rust.vim which is an external mirror of src/etc/vim.

@mmalecki
Copy link

@huonw nice, thanks for the link. Are there any plans to separate the code out? I can imagine it would make maintaining it, using it and contributing to it a lot easier.

@ghost
Copy link

ghost commented Apr 18, 2014

ok, wish this can be done.
We all waiting for it.

@felipecrv
Copy link

Reasons for this?

@klutzy
Copy link
Contributor

klutzy commented Oct 18, 2014

@huonw
Copy link
Member

huonw commented Feb 2, 2015

The extension is now in a separate repo, thanks to @steveklabnik: https://github.com/rust-lang/rust.vim

@huonw huonw closed this as completed Feb 2, 2015
RalfJung pushed a commit to RalfJung/rust that referenced this issue Jul 29, 2024
Add `gettid` support

Add support for `gettid` in miri.

To ensure that the requirement that  `getpid() == gettdi()` for the main thread, we use the value returned by `getpid` and add to it the internal thread index.

Since `getpid` is only supported when isolation is disabled, and we want `gettid` to be used both in isolated and non-isolated executions, we modify `getpid` to return a hardcoded value (1000) when running in isolation mode.

Fixes rust-lang#3730
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Development

No branches or pull requests