Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crates sidebar menu in docs disappears when page width is less than 700px #36531

Closed
carols10cents opened this issue Sep 16, 2016 · 0 comments
Closed
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@carols10cents
Copy link
Member

This can be confusing; it makes it look like there aren't any docs available. Example:

@bruceadams was following along with Chapter 2 in the new book, and we mention cargo doc --open after adding the regex crate. At the time he ran the command, his browser window was under 700px wide because he had his screen split to have the book and editor/terminal open at the same time, so the docs opened themselves in that narrow window. The menu with the crates in the sidebars is just totally gone at that width, and that combined with the fact that the guessing game doesn't have any docs that would appear on the index page makes the docs look broken and like there aren't any docs to browse :(

Screenshot of this scenario:

screen shot 2016-09-16 at 9 33 26 am

The problem is this CSS:

@media (max-width: 700px) {
   // ...
  .sidebar .block {
    display: none;
  }
  // ...
}

It'd be awesome to have at least a hamburger menu or something to be able to get to the menu of crates even at narrower widths.

@apasel422 apasel422 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Sep 28, 2016
@steveklabnik steveklabnik added T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. and removed T-tools labels May 18, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jul 26, 2017
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Dec 7, 2017
…ietMisdreavus

Greatly improve sidebar when width < 700px

Fixes rust-lang#36531.

r? @QuietMisdreavus

A few screenshots:

<img width="1440" alt="screen shot 2017-12-06 at 00 41 36" src="https://user-images.githubusercontent.com/3050060/33636875-6ad8b1a6-da1e-11e7-8d5b-d6d530ea5258.png">
<img width="1440" alt="screen shot 2017-12-06 at 00 41 40" src="https://user-images.githubusercontent.com/3050060/33636876-6af58196-da1e-11e7-82ab-b82768958037.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants