Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure spans on non_camel_case_types are correct #3522

Closed
brson opened this issue Sep 18, 2012 · 4 comments
Closed

Make sure spans on non_camel_case_types are correct #3522

brson opened this issue Sep 18, 2012 · 4 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-lints Area: Lints (warnings about flaws in source code) such as unused_mut.

Comments

@brson
Copy link
Contributor

brson commented Sep 18, 2012

I think they are pretty sloppy right now, pointing to the item instead of the ident

@ghost ghost assigned brson Sep 18, 2012
@brson
Copy link
Contributor Author

brson commented Sep 18, 2012

This can't be done without adding spans to idents, which is a sizable task.

@eholk
Copy link
Contributor

eholk commented Sep 18, 2012

This is probably an easier task after @paulstansifer's work on interning all the idents.

@catamorphism
Copy link
Contributor

Seems... non-critical. De-milestoning.

@emberian
Copy link
Member

@brson given the following test cases:

struct barz_type {
    a: uint,
    b: uint
}

fn main() {
    let x: barz_type = barz_type {a: 5};
}

and

fn main() {
    let x= barz_type {a: 5};
}

the spans are correct. Closing.

bors pushed a commit to rust-lang-ci/rust that referenced this issue May 15, 2021
Add a path to the parent dir of rustfmt.toml as a prefix to paths in ignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-lints Area: Lints (warnings about flaws in source code) such as unused_mut.
Projects
None yet
Development

No branches or pull requests

4 participants