path parens #3411
Comments
|
This is unfortunately to disambiguate the &str type from a reference mode argument. It can also be disambiguated by naming the argument, or we can wait until modes are gone and remove the parens. |
|
Yeah, this is temporary, this kind of thing can go away when we remove modes. We'll probably just do a big search and replace on |
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this issue
May 15, 2021
indicate that version-gate are to be considered only with changes to the default formatting
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this issue
Apr 16, 2024
Handle Miri sysroot entirely outside the Miri driver (Extracted from rust-lang/miri#3409) This entirely moves the responsibility of setting miri-sysroot to whatever *invokes* the Miri driver. cargo-miri knows whether it is inside rustdoc or not and can adjust accordingly. I previously avoided doing that because there are a bunch of places that are invoking the driver (cargo-miri, the ui test suite, `./miri run`, `./x.py run miri`) and they all need to be adjusted now. But it is also somewhat less fragile as we usually have more information there -- and we can just decide that `./miri run file.rs --sysroot path` is not supported. The advantage of this is that the driver is reasonably clean and doesn't need magic environment variables like MIRI_SYSROOT, and we don't have to fight rustc_driver to use a different default sysroot. Everything is done in cargo-miri (and the other much simpler driver wrappers) where it can hopefully be debugged much better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are these weird extra parens in the GenericPath trait like so
Not a big deal, but it's likely to confuse people who may think they take a tuple argument.
The text was updated successfully, but these errors were encountered: